Fix IconTintColorBehavior not tinting UriImageSource on Windows#1949
Merged
Conversation
…tint not applying to URIs
* Swap the order of checks to prevent an unnecessary exception from being thrown * Tidy up usage --------- Co-authored-by: Shaun Lawrence <17139988+bijington@users.noreply.github.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com>
TheCodeTraveler
previously approved these changes
Jun 18, 2024
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @myix765!
Just FYI - I added support for SVG images in LoadAndApplyImageTintColor(View, WImage, Color), and I added some Images to the IconTineColorBoehaviorPage in the sample app that use UriImageSource to ensure we have a way to regression test this bug in the future.
TheCodeTraveler
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Added check for if the bindable object has a UriImageSource and added it as a UriSource for the WImage control. Previously, the WImage control source was null.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Tested on Windows 10
This is an update to a previous PR #1929 which introduced a new issue, but this PR only addresses one of the issues linked in the old PR.