Skip to content

Set unloaded event to make sure popup is shown on Windows. #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeTraveler merged 7 commits into from
Jun 14, 2024
Merged

Set unloaded event to make sure popup is shown on Windows. #1932

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2ed5252
Set unloaded event to make sure popup is shown on Windows.
Jun 13, 2024
305251d
Fix memory leak
Jun 13, 2024
91d3fad
Use latest stable version of `Microsoft.Maui.Controls` and `Microsoft…
TheCodeTraveler Jun 14, 2024
e356f5a
Fix `UpdatingPopup` height
TheCodeTraveler Jun 14, 2024
b399953
Refactor code to use `sender`
TheCodeTraveler Jun 14, 2024
6fd4ded
Merge branch 'main' into bug-fix-popup-no-showing-on-second-try
TheCodeTraveler Jun 14, 2024
5e16d14
Merge branch 'main' into bug-fix-popup-no-showing-on-second-try
TheCodeTraveler Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/CommunityToolkit.Maui/Views/Popup/PopupExtensions.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ void handler(object? sender, EventArgs args)

async void handler(object? sender, EventArgs args)
{
page.GetCurrentPage().Unloaded -= (_, _) => { };
Comment thread
pictos marked this conversation as resolved.
Outdated
page.GetCurrentPage().Loaded -= handler;

try
Expand All @@ -76,6 +77,8 @@ async void handler(object? sender, EventArgs args)
taskCompletionSource.TrySetException(ex);
}
}

page.GetCurrentPage().Unloaded += (_, _) => { };
page.GetCurrentPage().Loaded += handler;

return taskCompletionSource.Task.WaitAsync(token);
Expand Down