Replace FrozenSet with IReadOnlyList#1839
Merged
Merged
Conversation
TheCodeTraveler
added
the
breaking change
pictos
previously approved these changes
Apr 28, 2024
VladislavAntonyuk
approved these changes
Apr 28, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR replaces
FrozenSetwithIReadOnlyList.This provides a workaround that resolves a crash caused by a bug in Mono / iOS: dotnet/runtime#101427
This also provides a performance improvement due to the high cost of creating a
FrozenSet: #1829 (comment)Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
This is a breaking change to our public API and will require a major version bump