Removes the transparent color set on Android when null#1584
Merged
Conversation
…icon tint color is set to null.
TheCodeTraveler
approved these changes
Nov 30, 2023
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @vhugogarcia!!
Just FYI - I updated the sample app to include a null Color for IconTintBehaviorPage. This'll help us to test + validate this bug to ensure we don't break it in future PRs.
Contributor
Author
|
Good catch @brminnick , thank you! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Removes the transparent color that was being set on Android when the icon tint color value is set to null.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PR