Skip to content

Remove SkiaSharp.Views Dependency#1547

Merged
TheCodeTraveler merged 2 commits into
mainfrom
remove-skiasharp-dependency
Nov 21, 2023
Merged

Remove SkiaSharp.Views Dependency#1547
TheCodeTraveler merged 2 commits into
mainfrom
remove-skiasharp-dependency

Conversation

@JoonghyunCho

@JoonghyunCho JoonghyunCho commented Nov 21, 2023

Copy link
Copy Markdown
Member

Description of Change

This PR removes the SkiaSharp.Views dependency for Tizen which has been added to remove the security vulnerability caused by Tizen.UIExtensions package.

Linked Issues

PR Checklist

Additional information

@JoonghyunCho JoonghyunCho added the do not merge Do not merge this PR label Nov 21, 2023
@JoonghyunCho

Copy link
Copy Markdown
Member Author

Check Dependencies step needs to be fixed to verify this PR.

@TheCodeTraveler

Copy link
Copy Markdown
Collaborator

Thanks @JoonghyunCho!

Good catch on the Check Dependencies step! I've fixed the pipeline, accidentally merging its fix into main, when I intended to merge the fix into this PR. 🙈

But the good news is that the Check Dependencies confirms that tizen-net8.0 is using the latest version of SkiaSharp, v2.88.6!

  [net8.0-tizen8.0]: 
   Top-level Package                            Requested   Resolved
   > Microsoft.Maui.Controls                    8.0.3       8.0.3   
   > Microsoft.Maui.Controls.Compatibility      8.0.3       8.0.3   

   Transitive Package                                           Resolved
   > Microsoft.Extensions.Configuration                         8.0.0   
   > Microsoft.Extensions.Configuration.Abstractions            8.0.0   
   > Microsoft.Extensions.DependencyInjection                   8.0.0   
   > Microsoft.Extensions.DependencyInjection.Abstractions      8.0.0   
   > Microsoft.Extensions.Logging                               8.0.0   
   > Microsoft.Extensions.Logging.Abstractions                  8.0.0   
   > Microsoft.Extensions.Options                               8.0.0   
   > Microsoft.Extensions.Primitives                            8.0.0   
   > Microsoft.Maui.Controls.Build.Tasks                        8.0.3   
   > Microsoft.Maui.Controls.Core                               8.0.3   
   > Microsoft.Maui.Controls.Xaml                               8.0.3   
   > Microsoft.Maui.Core                                        8.0.3   
   > Microsoft.Maui.Essentials                                  8.0.3   
   > Microsoft.Maui.Graphics                                    8.0.3   
   > Microsoft.Maui.Graphics.Skia                               8.0.3   
   > Microsoft.Maui.Resizetizer                                 8.0.3   
   > SkiaSharp                                                  2.88.6  
   > SkiaSharp.NativeAssets.Tizen                               2.88.6  
   > SkiaSharp.Views                                            2.88.6  
   > Tizen.UIExtensions.NUI                                     0.9.0  

@TheCodeTraveler TheCodeTraveler merged commit 220ec75 into main Nov 21, 2023
@TheCodeTraveler TheCodeTraveler deleted the remove-skiasharp-dependency branch November 21, 2023 17:47
@TheCodeTraveler TheCodeTraveler removed the do not merge Do not merge this PR label Nov 21, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Remove SkiaSharp.Views Dependency

3 participants