Fix IOS/MacOS AvataView background color with image bug#1539
Merged
TheCodeTraveler merged 4 commits intoNov 26, 2023
Conversation
Member
Author
|
@dotnet-policy-service agree |
TheCodeTraveler
approved these changes
Nov 26, 2023
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @TRybina132!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Bug] On iOS + MacCatalyst,
AvatarView.BackgroundColorDoes Not Work #509Description of Change
This bug occurs if we use any instance of class derived from
GeometryGroupas default clip for image in AvatarView on MacOs or IOS. In AvatarViewRoundRectangleGeometrywas used as default clip for image. This caused background color to overlay image.In this pull request I decided not to set clip object if AvatarView is used on IOS/MacOS with this approach background does not overlay image on IOS or MacOS and
RoundRectangleGeometrystill be used as default image clip for other platforms.How it looks in MacOS
In IOS
