Skip to content

Use fully qualified namespace for Colors reference in TextToColorGenerator#1536

Merged
TheCodeTraveler merged 1 commit into
CommunityToolkit:mainfrom
IIARROWS:bugfix/1535-fix-ambiguous-colors-generator
Nov 18, 2023
Merged

Use fully qualified namespace for Colors reference in TextToColorGenerator#1536
TheCodeTraveler merged 1 commit into
CommunityToolkit:mainfrom
IIARROWS:bugfix/1535-fix-ambiguous-colors-generator

Conversation

@IIARROWS

Copy link
Copy Markdown
Contributor

This change should prevent "ambiguous reference" error to occur when other packages are included in a MAUI project that provide their own Color objects.

Examples of such libraries is MudBlazor.

Description of Change

In the source code generator use a fully qualified namespace to the Color object, so Color is changed into global::Microsoft.Maui.Graphics.Colors following the example for the similar solution for of #1331

As per previous PR, no tests added, current tests are sufficient to cover this change (and using the wrong value fail).

Linked Issues

PR Checklist

Additional information

@IIARROWS

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@TheCodeTraveler TheCodeTraveler enabled auto-merge (squash) November 18, 2023 19:22
@TheCodeTraveler TheCodeTraveler merged commit 8b62999 into CommunityToolkit:main Nov 18, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Ambiguous reference error occurs when other package is included that provides its own Colors object

2 participants