Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable roaming user settings via OneDrive #85

Merged
merged 7 commits into from
Apr 15, 2021

Conversation

shweaver-MSFT
Copy link
Member

@shweaver-MSFT shweaver-MSFT commented Apr 5, 2021

Fixes #74

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Storing data in OneDrive is possible today, but still requires some effort to integrate with the SDK.

What is the new behavior?

I've added a new base implementation of the IRoamingSettingsDataStore called BaseRoamingSettingsDataStore, and built a new OneDriveDataStore on top.

var roamingSettings = RoamingSettingsHelper.CreateForCurrentUser(RoamingDataStore.OneDrive);

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

// TODO:

  • Add tests

@shweaver-MSFT shweaver-MSFT self-assigned this Apr 5, 2021
@ghost
Copy link

ghost commented Apr 5, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned michael-hawker Apr 5, 2021
@shweaver-MSFT shweaver-MSFT changed the base branch from main to dev April 5, 2021 19:15
@shweaver-MSFT shweaver-MSFT marked this pull request as ready for review April 9, 2021 00:20
@shweaver-MSFT
Copy link
Member Author

I haven't had a chance to fulllllllly test this yet, but feel free to start reviewing. Once the WindowsProvider is added, it'll be easier for me to go back and add tests that actually talk to the Graph. The current tests only use the local cache.

@shweaver-MSFT
Copy link
Member Author

Now that the WindowsProvider is checked in, I was able to give it a more thorough test pass and it checks out :)

@shweaver-MSFT shweaver-MSFT merged commit 09184fd into dev Apr 15, 2021
@shweaver-MSFT shweaver-MSFT deleted the shweaver/roaming-onedrive2 branch April 15, 2021 22:13
shweaver-MSFT added a commit that referenced this pull request Apr 19, 2021
…onedrive2"

This reverts commit 09184fd, reversing
changes made to d097b16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Enable roaming settings via OneDrive file storage
2 participants