-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable roaming user settings via OneDrive #85
Conversation
Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
I haven't had a chance to fulllllllly test this yet, but feel free to start reviewing. Once the WindowsProvider is added, it'll be easier for me to go back and add tests that actually talk to the Graph. The current tests only use the local cache. |
Now that the WindowsProvider is checked in, I was able to give it a more thorough test pass and it checks out :) |
Fixes #74
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Storing data in OneDrive is possible today, but still requires some effort to integrate with the SDK.
What is the new behavior?
I've added a new base implementation of the
IRoamingSettingsDataStore
calledBaseRoamingSettingsDataStore
, and built a newOneDriveDataStore
on top.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
// TODO: