Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding UnitTests project with example tests for MockProvider #79

Merged
merged 4 commits into from
Mar 25, 2021

Conversation

shweaver-MSFT
Copy link
Member

@shweaver-MSFT shweaver-MSFT commented Mar 23, 2021

Fixes #80

PR Type

What kind of change does this PR introduce?

  • Other: Testing

What is the current behavior?

There is currently no test infrastructure in the Graph-Controls repo.

What is the new behavior?

I've added a test project for running unit tests against UWP, modeled after the setup in WCT. I could have split it into multiple test projects (Net and Uwp), but I didn't see a strong reason to up front.

For starters I've added unit tests for the MockProvider

  • Default construction
  • Login
  • Logout
  • Authenticate a request

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Getting test infrastructure is not only a generally good thing for the project (detecting regressions, etc.), but it also will make it easy to demonstrate project stability to our first adopters.

@ghost
Copy link

ghost commented Mar 23, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@shweaver-MSFT shweaver-MSFT requested a review from nmetulev March 25, 2021 18:36
@nmetulev nmetulev merged commit cb55009 into dev Mar 25, 2021
@nmetulev nmetulev deleted the shweaver/unit-tests branch March 25, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants