Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors. #70

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Fix build errors. #70

merged 2 commits into from
Feb 11, 2021

Conversation

azchohfi
Copy link
Collaborator

@azchohfi azchohfi commented Feb 11, 2021

Fixes #68

I'm also updating some dependencies to have the latest fixes.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Build or CI related changes

What is the current behavior?

Broken build

What is the new behavior?

Build passing fine.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Feb 11, 2021

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Member

@shweaver-MSFT shweaver-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Alex! 🚀🚀🚀 No more build errors

@azchohfi
Copy link
Collaborator Author

I'm gonna merge this, as its a minor fix, and important for your other PR.

@azchohfi azchohfi merged commit 7a148f7 into main Feb 11, 2021
@azchohfi azchohfi deleted the fixBuild branch February 11, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update NuGet.config
3 participants