Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to VS 2022 Build Process #202

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Conversation

michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Dec 15, 2022

Existing Build got broken with environment changes it seems, so worked to bring us up to VS 2022 VM and build system on .NET 6.

Includes:

  • Updating dependencies
  • Removes Cake!
  • Uses dotnet/msbuild to build in Azure DevOps directly
  • Moves Stylecop to .editorconfig
  • Moves to .NET 6 for build and targets
  • Fixes build configuration for CI to only build required libraries and not samples
  • Renames Net5Windows example to NetWindows

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes

What is the current behavior?

Can't Build repo in VS 2022 and in CI

What is the new behavior?

Can build in VS 2022 locally, on commandline, and in CI

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Dec 15, 2022

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@michael-hawker michael-hawker force-pushed the michael-hawker/update-build branch 4 times, most recently from f67b7cd to 759a047 Compare December 15, 2022 09:32
Update dependencies
Removes Cake call from azurepipeline.yml (after attempting to upgrade, will remove files in separate commit)
Uses dotnet/msbuild to build and run tests in Azure DevOps directly
Moves Stylecop to .editorconfig
Moves to .NET 6 for build and targets
Fixes build configuration for CI to only build required libraries and not samples
Renames Net5Windows example to NetWindows
XAML Styler check removed see #203
@michael-hawker
Copy link
Member Author

@niels9001 @Arlodotexe mind taking a look? Think this is a fairly straight-forward swap out in the end; but took a bit of trial and error (realized tests are interactive currently, and build variable wasn't being replaced).

Would like to merge this in the morning and then close out the remaining open PRs together so we can get a new 7.1.3 out. I notified @Richasy to help test out the PR bits as well in comparison to 7.1.2 to ensure we don't get any surprises.

Though did a quick comparison in NuGet Package Explorer:

7.1.2 packages:

image

image

New PR packages:

image

image

Outside of the signing step (which was unchanged, just not done for PRs), the package construction looks identical to me.

Copy link

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-hawker Yeah packages look pretty much identical and no unexpected changes as far as I can judge :). Good if @Arlodotexe can do a quick scan as well :)

@michael-hawker
Copy link
Member Author

Not sure of the old behavior of the Unit Tests, or something changed with an MSAL update or something:

image

Seems to have to do with auto-signin but setting that property to false doesn't help. We'll have to shore up tests in the future later if we invest more in larger changes and investments to the library in the future.

@michael-hawker michael-hawker added this to the 7.1.3 milestone Dec 15, 2022
@michael-hawker michael-hawker merged commit 8b39a18 into main Dec 15, 2022
@michael-hawker michael-hawker deleted the michael-hawker/update-build branch December 15, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants