Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding empty providers #191

Merged

Conversation

Richasy
Copy link
Contributor

@Richasy Richasy commented Jun 14, 2022

Fixes #190

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When adding a WebAccountProvider, there is no null judgment on the acquired provider, resulting in a null reference in the provider added to the list, which directly causes an unexpected provider (null) to be passed in when the WebAccountProviderCommand is created, causing the process to be interrupted and unable to log in.

What is the new behavior?

Create a new method and add it to the list only when the obtained WebAccountProvider is not null.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@shweaver-MSFT
Copy link
Member

Need to clean up the build error, but otherwise looks good to me :)

@michael-hawker
Copy link
Member

Looks like it may have been a NuGet timeout trying to restore packages, reran the job, so we'll see what happens.

@michael-hawker michael-hawker merged commit d985141 into CommunityToolkit:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account panel exits after selecting account type
4 participants