fix(msalprovider): Fix error when providing TenantId

[brekkjen]

Fixes #170

https://github.com//issues/170

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

Providing TenantId causes both WithTenantId and WithAuthority to be specified and those are mutually exclusive resulting in error

What is the new behavior?

Providing TenantId excludes WithAuthority

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

Other information

[ghost]

Thanks brekkjen for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[net-foundation-cla]

All CLA requirements met.

[shweaver-MSFT]

Thanks for submitting, and sorry it took me a few days to get to it. I've got one nitpick, now that the authority is only required if the tenantId is null, we should move the authority declaration into the else statement closest to where it's being used.

if (tenantId != null)
{
    clientBuilder = clientBuilder.WithTenantId(tenantId);
}
else
{
    // If the TenantId is not provided, use WithAuthority
    var authority = listWindowsWorkAndSchoolAccounts ? AadAuthorityAudience.AzureAdAndPersonalMicrosoftAccount : AadAuthorityAudience.PersonalMicrosoftAccount;
    clientBuilder = clientBuilder.WithAuthority(AzureCloudInstance.AzurePublic, authority);
}

Then we should be good to go 👍

[brekkjen]

Yes, i agree.