Update MsalProvider to use native account broker #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
XAML-Knight
suggested changes
Oct 19, 2021
ghost
added
the
CommunityToolkit.Authentication/Extensions/HttpRequestMessageExtensions.cs
Outdated
Show resolved
Hide resolved
michael-hawker
approved these changes
Oct 20, 2021
… added WpfNetCoreMsalProviderSample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168
Fixes #170
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the MsalProvider does not invoke the native account broker in Windows, even when it is available. Users always see the web-based prompt, even when using the MsalProvider in UWP.
What is the new behavior?
I've made a few changes:
CommunityToolkit.Authentication.Msalpackage to multi-targetuap10.0,netstandard3.1, andnet5.0-windows10.0.17763.0as well as the existing target fornetstandard2.0. This enables the Windows account broker to work for those additional frameworks.MsalProviderto use the appropriate APIs depending on where the app is running (UWP/Net5-Windows or otherwise).PublicClientApplicationobject.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
A good way to test is by firing up the UwpMsalProviderSample, WpfNet5WindowsMsalProviderSample, and WpfNetCoreMsalProviderSample samples and compare the experience.
More info on the cache situation can be found here: https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/wiki/Cross-platform-Token-Cache