Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mock service endpoint in MockProvider #141

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

shweaver-MSFT
Copy link
Member

Fixes #140

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

MockProvider is currently broken because the underlying service endpoint changed.

What is the new behavior?

Instead of pointing to a hardcoded proxy url, we now make a request to a middle service to get the proxy url, and then use that for any outgoing requests.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Aug 4, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@shweaver-MSFT shweaver-MSFT changed the base branch from dev/7.1.0 to main August 6, 2021 17:47
@shweaver-MSFT shweaver-MSFT merged commit 28e919f into main Aug 6, 2021
@shweaver-MSFT shweaver-MSFT deleted the shweaver/mock-provider-fix branch August 6, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MockProvider
1 participant