Major refactor of PersonView with new sample page #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
| FontWeight="SemiBold" | ||
| Text="{Binding PersonDetails.DisplayName, RelativeSource={RelativeSource TemplatedParent}}" /> | ||
| </controls:Case> | ||
| <Grid Grid.Column="1"> |
There was a problem hiding this comment.
Can't we just set the Column on both the children rather than introducing another Grid layer?
There was a problem hiding this comment.
Definitely. I found another bug in that file as well. I'll fix them at the same time :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10, #6, #26, #28
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The PersonView has a few bugs, and after looking through the code I decided a bit of refactoring would make it easier to read and maintain, as well as naturally fixing some bugs inherent in the previous model.
What is the new behavior?
PersonAvatarType-PhotoorInitialsUserPhotosetter is now internalProviderStatesenumPersonViewTypeenum value,ThreeLinesPersonViewSamplepagePR Checklist
Please check if your PR fulfills the following requirements:
Other information