Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated OnProviderStateChanged method #129

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Conversation

shweaver-MSFT
Copy link
Member

Fixes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

This is a one word change:

// OLD
private void OnProviderStateChanged(object sender, ProviderStateChangedEventArgs args)
{
    ProviderStateChanged?.Invoke(sender, args); // <- 'sender' is wrong
    PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(nameof(State)));
}

// NEW
private void OnProviderStateChanged(object sender, ProviderStateChangedEventArgs args)
{
    ProviderStateChanged?.Invoke(this, args); <- Need to use 'this' instead
    PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(nameof(State)));
}

This is inspired by a recent bugfix in main.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jul 19, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@shweaver-MSFT shweaver-MSFT merged commit 6ec457e into dev/7.1.0 Jul 19, 2021
@shweaver-MSFT shweaver-MSFT deleted the shweaver/124 branch July 19, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant