Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes race condition issue with OnProviderStateChanged event. #125

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

pekspro
Copy link
Contributor

@pekspro pekspro commented Jul 18, 2021

Fixes #124

PR Type

Bugfix

@net-foundation-cla
Copy link

net-foundation-cla bot commented Jul 18, 2021

CLA assistant check
All CLA requirements met.

@shweaver-MSFT
Copy link
Member

Hey @pekspro, thanks for submitting this! The fix looks great. I'm not sure what is up with the build failure, but I'm experiencing the same issue on the main WCT repo as well. @michael-hawker any idea what's going on with the build CI?

@shweaver-MSFT
Copy link
Member

shweaver-MSFT commented Jul 19, 2021

@pekspro, we figured out the build issue. It was caused by a recent org name change in WCT, and the fix has been pushed to main branch. Please merge in the latest from main to get the build fixed up.

@pekspro
Copy link
Contributor Author

pekspro commented Jul 19, 2021

Thanks @shweaver-MSFT. I have synced the code and now it compiles :-)

@shweaver-MSFT
Copy link
Member

Looks good! Merging in now

@shweaver-MSFT shweaver-MSFT merged commit 2daf81e into CommunityToolkit:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition issue when subscribing to ProviderStateChanged
2 participants