Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed scopes param from IProvider.GetTokenAsync #123

Merged
merged 3 commits into from
Jul 27, 2021

Conversation

shweaver-MSFT
Copy link
Member

@shweaver-MSFT shweaver-MSFT commented Jul 12, 2021

Fixes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

WAM doesn't support incremental consent, so this function is deceiving. Only pre-authorized scopes will return a token successfully, in which case they should be included with the rest of the scopes provided during provider construction.

What is the new behavior?

I've removed the scopes param from IProvider.GetTokenAsync.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Docs PR: MicrosoftDocs/WindowsCommunityToolkitDocs#542

@ghost
Copy link

ghost commented Jul 12, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned azchohfi Jul 12, 2021
@shweaver-MSFT shweaver-MSFT added this to the 7.0.0 milestone Jul 12, 2021
@shweaver-MSFT
Copy link
Member Author

Code is done, CI passed. Waiting on docs PR

@shweaver-MSFT shweaver-MSFT modified the milestones: 7.0.0, 7.1.0 Jul 27, 2021
@shweaver-MSFT
Copy link
Member Author

Merging in. We'll get the docs updated before the preview release in the next few weeks.

@shweaver-MSFT shweaver-MSFT merged commit ad431bc into main Jul 27, 2021
@shweaver-MSFT shweaver-MSFT deleted the shweaver/token-fix-main branch July 27, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants