Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up CommunityToolkit.Authentication.Uwp csproj file #119

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

shweaver-MSFT
Copy link
Member

Fixes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

It was reported that there are issues building the CommunityToolkit.Authentication.Uwp project, so I took the opportunity to clean up the csproj file and make it more similar to that of UWP projects in WCT.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@shweaver-MSFT shweaver-MSFT self-assigned this Jun 23, 2021
@ghost
Copy link

ghost commented Jun 23, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned michael-hawker Jun 23, 2021
@shweaver-MSFT shweaver-MSFT merged commit 6ff836b into main Jun 23, 2021
@shweaver-MSFT shweaver-MSFT deleted the shweaver/main-csproj branch June 23, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants