Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted uwp project files to match WCT. #118

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

shweaver-MSFT
Copy link
Member

@shweaver-MSFT shweaver-MSFT commented Jun 22, 2021

Also updated some broken tests after provider event name change, and a bug in the LoginButton.

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

WCT uses a special csproj format for UWP projects, and the Graph-Controls repo should match.

Here is an example from WCT:
https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/main/Microsoft.Toolkit.Uwp.UI.Controls.Input/Microsoft.Toolkit.Uwp.UI.Controls.Input.csproj

What is the new behavior?

The csproj formats in the following packages now match the way WCT handles UWP projects:

  1. CommunityToolkit.Authentication.Uwp
  2. CommunityToolkit.Graph.Uwp

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@shweaver-MSFT shweaver-MSFT self-assigned this Jun 22, 2021
@ghost
Copy link

ghost commented Jun 22, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@shweaver-MSFT shweaver-MSFT merged commit 5826b60 into dev/7.1.0 Jun 23, 2021
@shweaver-MSFT shweaver-MSFT deleted the shweaver/uwp-csproj branch June 23, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants