Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated LoginButton events to respond to GlobalProvider #115

Merged
merged 4 commits into from
Jul 12, 2021

Conversation

shweaver-MSFT
Copy link
Member

@shweaver-MSFT shweaver-MSFT commented Jun 11, 2021

Fixes #101

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Currently, the Login/Logout-Completed events on LoginButton only fire when actually interacting with the button. This can make it difficult to use the LoginButton events reliably, since they won't fire if the GlobalProvider is updated directly.

What is the new behavior?

The new behavior allows the LoginButton to emit Login/Logout-Completed events in response to state changes in the GlobalProvider. When the GlobalProvider state changes, the LoginButton will emit those events as appropriate.

Note: The Login/Logout-Initiated events will not fire. This is because we have limited ability to understand the login flow based on the ProviderState enum values, SignedIn, SignedOut, and Loading.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jun 11, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@shweaver-MSFT shweaver-MSFT self-assigned this Jun 29, 2021
@shweaver-MSFT shweaver-MSFT modified the milestone: 7.1.0 Jun 29, 2021
@shweaver-MSFT shweaver-MSFT merged commit 8ac8c8c into dev/7.1.0 Jul 12, 2021
@shweaver-MSFT shweaver-MSFT deleted the shweaver/login-events branch July 12, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants