Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CurrentAccountId to IProvider #109

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Conversation

shweaver-MSFT
Copy link
Member

@shweaver-MSFT shweaver-MSFT commented Jun 3, 2021

Fixes #

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

This PR introduces a new property on IProvider called CurrentAccountId, which reflects the identifier of the currently signed in user account.

  • For MsalProvider the id comes from Microsoft.Identity.Client.AccountId.Identifier
  • For WindowsProvider the id comes from Windows.Security.Credentials.WebAccount.Id
  • For MockProvider the id is a dummy value, "mock-account-id".

When NOT signed in CurrentAccountId returns null.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@shweaver-MSFT shweaver-MSFT self-assigned this Jun 3, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@shweaver-MSFT
Copy link
Member Author

This comes from an internal request.

Also, don't forget to merge this into main as well.

@shweaver-MSFT shweaver-MSFT merged commit 2fa4c39 into dev/7.1.0 Jun 4, 2021
@shweaver-MSFT shweaver-MSFT deleted the shweaver/account-id branch June 4, 2021 18:39
shweaver-MSFT added a commit that referenced this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants