GlobalProvider setter should emit ProviderUpdated event for ProviderStateChanged #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
|
REMINDER: Don't forget to also cherry-pick this back into |
shweaver-MSFT
added a commit
that referenced
this pull request
Jun 4, 2021
…tateChanged (#108) * Emit ProviderStateChanged event from GlobalProvider setter * Updated references to old pattern and removed some stale docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, when setting the
ProviderManager.Instance.GlobalProviderto an instance ifIProvider, theProviderManagerwill emit a singleProviderUpdatedevent with the reason beingProviderManagerChangedState.ProviderChanged.What is the new behavior?
With these changes, the
ProviderManagerwill now emit a secondProviderUpdatedevent with the reason beingProviderManagerChangedState.ProviderStateChanged.This will enable developers to more easily differentiate between changes to the GlobalProvider instance, versus changes in the ProviderState of the current GlobalProvider instance.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information