-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New extension for toggling element visibility based on the GlobalProvider state #106
Conversation
Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Thanks for the feedback @michael-hawker :) Thinking about naming as well since it is a bit verbose... What do you think about: <TextBlock wgt:ProviderExtensions.IsVisibleWhen="SignedIn" Text="Only visible when signed in" />
<TextBlock wgt:ProviderExtensions.IsVisibleWhen="SignedOut" Text="Only visible when signed out" />
<TextBlock wgt:ProviderExtensions.IsVisibleWhen="Loading" Text="You get the picture" />
Thoughts? What do you think @nmetulev? I'm very open to other naming ideas 😅 |
@michael-hawker, also curious on your thoughts for restructuring the naming scheme ^ |
Contributes to #97
PR Type
What kind of change does this PR introduce?
What is the new behavior?
You can now toggle visibility for elements based on the specified provider state:
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
I'm not totally in love with "ElementExtensions" as the name, but don't have any better ideas and it is better than "FrameworkElementExtensions" which I think is just too long for simple usage in XAML. "ProviderExtensions" and "GraphExtensions" seem interesting, but we aren't really extending the providers or Graph client. I'm open to input.