Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed preview controls/helpers and any references #103

Merged
merged 4 commits into from
May 20, 2021

Conversation

shweaver-MSFT
Copy link
Member

@shweaver-MSFT shweaver-MSFT commented May 20, 2021

We are preparing to release soon, but only a few of the packages are ready. The CommunityToolkit.Graph.Uwp project is still preview and should not be included in the release.

I've created a preview branch which is a copy of main as a backup.

In the remove-preview branch (this one), I then removed all references to the preview package, including the SampleTest app. There are 3 working samples in the sample folder which demonstrate authentication with the Windows/Msal providers and making a Graph call using the ProviderExtensions.

After we ship this first release, we can then bring the components and helpers back in as they are ready.

@ghost
Copy link

ghost commented May 20, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned Kyaa-dost May 20, 2021
@shweaver-MSFT
Copy link
Member Author

The preview branch has been replaced by the dev/7.1.0 branch, which is connected to the CI to produce nuget packages.

@shweaver-MSFT
Copy link
Member Author

shweaver-MSFT commented May 20, 2021

The new preview dev/7.1.0 packages are working great in the notes app. We are safe to trim the preview content from main now 👍

@shweaver-MSFT shweaver-MSFT merged commit a7c53db into main May 20, 2021
@shweaver-MSFT shweaver-MSFT deleted the shweaver/remove-preview branch May 20, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants