xUnit v3 upgrade #960
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ on: | |
| workflow_dispatch: | ||
|
|
||
| env: | ||
| DEFAULT_DOTNET_VERSION: "10.0.x" | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ on: | |
| - "v*" | ||
|
|
||
| env: | ||
| DEFAULT_DOTNET_VERSION: "10.0.x" | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,7 @@ jobs: | |
| dotnet-version: | | ||
| 8.0.x | ||
| 9.0.x | ||
| 10.0.x | ||
|
|
||
| - name: Get git tag | ||
| id: git_tag | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,36 +2,49 @@ | |||||||||||||||||||||||||||||||||
| "version": "2.0.0", | ||||||||||||||||||||||||||||||||||
| "tasks": [ | ||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||
| "label": "build", | ||||||||||||||||||||||||||||||||||
| "command": "dotnet", | ||||||||||||||||||||||||||||||||||
| "type": "process", | ||||||||||||||||||||||||||||||||||
| "args": [ | ||||||||||||||||||||||||||||||||||
| "build", | ||||||||||||||||||||||||||||||||||
| "/property:GenerateFullPaths=true", | ||||||||||||||||||||||||||||||||||
| "/consoleloggerparameters:NoSummary;ForceNoAlign" | ||||||||||||||||||||||||||||||||||
| ], | ||||||||||||||||||||||||||||||||||
| "problemMatcher": "$msCompile" | ||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||
| "label": "publish", | ||||||||||||||||||||||||||||||||||
| "command": "dotnet", | ||||||||||||||||||||||||||||||||||
| "type": "process", | ||||||||||||||||||||||||||||||||||
| "args": [ | ||||||||||||||||||||||||||||||||||
| "publish", | ||||||||||||||||||||||||||||||||||
| "/property:GenerateFullPaths=true", | ||||||||||||||||||||||||||||||||||
| "/consoleloggerparameters:NoSummary;ForceNoAlign" | ||||||||||||||||||||||||||||||||||
| ], | ||||||||||||||||||||||||||||||||||
| "problemMatcher": "$msCompile" | ||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||
| "label": "watch", | ||||||||||||||||||||||||||||||||||
| "command": "dotnet", | ||||||||||||||||||||||||||||||||||
| "type": "process", | ||||||||||||||||||||||||||||||||||
| "args": [ | ||||||||||||||||||||||||||||||||||
| "watch", | ||||||||||||||||||||||||||||||||||
| "run" | ||||||||||||||||||||||||||||||||||
| ], | ||||||||||||||||||||||||||||||||||
| "problemMatcher": "$msCompile" | ||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||
| "label": "cleanup", | ||||||||||||||||||||||||||||||||||
| "type": "shell", | ||||||||||||||||||||||||||||||||||
| "command": "./eng/clean-bin-obj.sh", | ||||||||||||||||||||||||||||||||||
| "problemMatcher": [], | ||||||||||||||||||||||||||||||||||
| "linux": { | ||||||||||||||||||||||||||||||||||
| "options": { | ||||||||||||||||||||||||||||||||||
| "shell": { | ||||||||||||||||||||||||||||||||||
| "executable": "bash" | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. The new
Suggested change
|
||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
| ], | ||||||||||||||||||||||||||||||||||
| "inputs": [ | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,85 @@ | ||||||||||||
| #!/usr/bin/env bash | ||||||||||||
| # Recursively delete all `bin` and `obj` folders from the repository. | ||||||||||||
| # Usage: ./eng/clean-bin-obj.sh | ||||||||||||
| # Optional flags: | ||||||||||||
| # --dry-run Show what would be removed without deleting. | ||||||||||||
| # --quiet Suppress per-folder output; only show summary. | ||||||||||||
| # --help Display help. | ||||||||||||
| # | ||||||||||||
| # The script resolves the repo root based on its own location so it can be | ||||||||||||
| # invoked from any working directory. | ||||||||||||
|
|
||||||||||||
| set -euo pipefail | ||||||||||||
|
|
||||||||||||
| print_help() { | ||||||||||||
| cat <<'EOF' | ||||||||||||
| Clean bin/obj folders | ||||||||||||
|
|
||||||||||||
| Deletes ALL directories named `bin` or `obj` under the repository root. | ||||||||||||
|
|
||||||||||||
| Flags: | ||||||||||||
| --dry-run List directories that would be deleted. | ||||||||||||
| --quiet Only print summary information. | ||||||||||||
| --help Show this help text. | ||||||||||||
|
|
||||||||||||
| Examples: | ||||||||||||
| ./eng/clean-bin-obj.sh | ||||||||||||
| ./eng/clean-bin-obj.sh --dry-run | ||||||||||||
| ./eng/clean-bin-obj.sh --quiet | ||||||||||||
| EOF | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| DRY_RUN=0 | ||||||||||||
| QUIET=0 | ||||||||||||
| for arg in "$@"; do | ||||||||||||
| case "$arg" in | ||||||||||||
| --dry-run) DRY_RUN=1 ;; | ||||||||||||
| --quiet) QUIET=1 ;; | ||||||||||||
| --help|-h) print_help; exit 0 ;; | ||||||||||||
| *) echo "Unknown argument: $arg" >&2; exit 1 ;; | ||||||||||||
| esac | ||||||||||||
| done | ||||||||||||
|
|
||||||||||||
| # Determine repo root (parent of this script's directory) | ||||||||||||
| SCRIPT_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd) | ||||||||||||
| REPO_ROOT=$(cd "${SCRIPT_DIR}/.." && pwd) | ||||||||||||
|
|
||||||||||||
| cd "$REPO_ROOT" | ||||||||||||
|
|
||||||||||||
| # Collect bin/obj directories excluding anything under .git to be safe. | ||||||||||||
| # Use -prune to avoid descending into matched directories after they are found. | ||||||||||||
| mapfile -t TARGETS < <(find . -type d \( -name bin -o -name obj \) -not -path '*/.git/*' -prune -print) | ||||||||||||
|
There was a problem hiding this comment. This script uses
Suggested change
|
||||||||||||
|
|
||||||||||||
| COUNT=${#TARGETS[@]} | ||||||||||||
| if [[ $COUNT -eq 0 ]]; then | ||||||||||||
| [[ $QUIET -eq 0 ]] && echo "No bin/obj directories found under $REPO_ROOT." || true | ||||||||||||
| exit 0 | ||||||||||||
| fi | ||||||||||||
|
|
||||||||||||
| if [[ $DRY_RUN -eq 1 ]]; then | ||||||||||||
| [[ $QUIET -eq 0 ]] && printf '%s\n' "Dry run: the following $COUNT directories would be deleted:" || true | ||||||||||||
| printf '%s\n' "${TARGETS[@]}" | ||||||||||||
| exit 0 | ||||||||||||
| fi | ||||||||||||
|
|
||||||||||||
| # Delete directories. | ||||||||||||
| DELETED=0 | ||||||||||||
| for dir in "${TARGETS[@]}"; do | ||||||||||||
| if [[ $QUIET -eq 0 ]]; then | ||||||||||||
| echo "Removing: $dir" | ||||||||||||
| fi | ||||||||||||
| rm -rf "$dir" || { | ||||||||||||
| echo "Failed to remove: $dir" >&2 | ||||||||||||
| continue | ||||||||||||
| } | ||||||||||||
| # Increment without triggering set -e early exit (arithmetic exit status is 1 when result is 0 for post-increment) | ||||||||||||
| ((DELETED++)) || true | ||||||||||||
| done | ||||||||||||
|
|
||||||||||||
| if [[ $QUIET -eq 0 ]]; then | ||||||||||||
| echo "Removed $DELETED bin/obj directories under $REPO_ROOT." | ||||||||||||
| else | ||||||||||||
| echo "Removed $DELETED directories." # Always show a minimal summary in quiet mode. | ||||||||||||
| fi | ||||||||||||
|
|
||||||||||||
| exit 0 | ||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,6 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <RootNamespace>Messaging</RootNamespace> | ||
| </PropertyGroup> | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,9 +2,6 @@ | |
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,9 +4,6 @@ | |
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <IsAspireHost>true</IsAspireHost> | ||
| <UserSecretsId>bc193f31-c9f7-4e3d-b70a-0dc39ec3047f</UserSecretsId> | ||
| </PropertyGroup> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to:
--logger "console;verbosity=normal".--logger trxwith--report-trx(and ensure Microsoft.Testing.Extensions.TrxReport is referenced)--crashdump,--hangdump, and--hangdump-timeout 7m--results-directoryis changing the meaning a little bit with this PR. Previously it would be relative to current working directory${{ github.workspace }}while with this PR it will be relative to the test executable. So either pass the full path, or keep usingdotnet testwhich will handle the path transformation for you.--collect "XPlat Code Coverage"needs to be replaced with--coverage(and ensure Microsoft.Testing.Extensions.CodeCoverage is referenced)