-
Notifications
You must be signed in to change notification settings - Fork 138
Implement GetConnectionProperties for new connection string formatting #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aaronpowell
merged 32 commits into
main
from
copilot/adapt-connection-string-formatting
Nov 11, 2025
Merged
Changes from 31 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
7efe0a9
baseline branch for the next major release
aaronpowell 263500f
Initial plan
Copilot 456ec42
Implement GetConnectionProperties for all IResourceWithConnectionStri…
Copilot 2ebfea3
Updating nightly
aaronpowell 06d5985
Remove deprecated IDistributedApplicationLifecycleHook interface (#915)
Copilot 1cac8f7
Merge branch 'aspire-13' into copilot/adapt-connection-string-formatting
aaronpowell 3998714
Merge branch 'main' into aspire-13
aaronpowell 8854f05
Adjusting the version of keycloak
aaronpowell e347742
Merge branch 'aspire-13' into copilot/adapt-connection-string-formatting
aaronpowell 8ed05c2
Updating aspire nightly
aaronpowell 021a7ae
Merge branch 'main' into aspire-13
aaronpowell 573fa53
New nightly
aaronpowell f20ff5b
Handling url encoding
aaronpowell beff6c8
Merge branch 'aspire-13' into copilot/adapt-connection-string-formatting
aaronpowell 18787c3
Remove npm functionality moved to Aspire 13 (#928)
Copilot b8f82f3
Merge branch 'aspire-13' into copilot/adapt-connection-string-formatting
aaronpowell eef3b5c
Merge branch 'main' into aspire-13
aaronpowell 7c3b2aa
Merge branch 'aspire-13' of https://github.com/CommunityToolkit/Aspir…
aaronpowell 747ee02
Merge branch 'aspire-13' into copilot/adapt-connection-string-formatting
aaronpowell 76cfd8e
Fixing failing test
aaronpowell 5352dc5
Merge branch 'aspire-13' into copilot/adapt-connection-string-formatting
aaronpowell f592c54
Merge branch 'main' into aspire-13
aaronpowell 9dd878d
Add GetConnectionProperties implementation to MinioContainerResource
Copilot 750eeb7
Add GetConnectionProperties to KurrentDB and LavinMQ resources
Copilot fbf5bd7
Handling uri encoding which requires a reference expression wrapper
aaronpowell acf869e
Don't need to escape in the connection string as we now encode properly
aaronpowell 92071f1
Merge branch 'aspire-13' into copilot/adapt-connection-string-formatting
aaronpowell 9d6a637
Merge branch 'main' into copilot/adapt-connection-string-formatting
aaronpowell 6e33779
Reverting some changes that weren't needed
aaronpowell 6cb9b79
Fixing minio encoding in tests
aaronpowell 986ba62
Removing URL encoding as the client doesn't decode it
aaronpowell e732a27
forgot to revert some changes in tests
aaronpowell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At what point will it be able to use the encoding from 13.0 (
Password:uri)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastienros sorry, I'm not sure I'm following
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add
:uriformatter suffix on values that need to be url-encoded:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, TIL.
@copilot can you do this