Skip to content

Conversation

@aaronpowell
Copy link
Member

@aaronpowell aaronpowell commented May 23, 2025

Update project references and improve app setup

  • Added project reference for CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.csproj in CommunityToolkit.Aspire.StaticWebApps.AppHost.csproj.
  • Changed web app setup in Program.cs from .AddNpmApp to .AddViteApp with .WithNpmPackageInstallation().
  • Modified Port property in SwaResourceOptions.cs to use a random port between 4280 and 5280.
  • Updated tests in SwaHostingComponentTests.cs to utilize CancellationToken for better control over async operations.

Related Work Items: #698, #677

Closes #<ISSUE_NUMBER>

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Update project references and improve app setup

- Added project reference for `CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.csproj` in `CommunityToolkit.Aspire.StaticWebApps.AppHost.csproj`.
- Changed web app setup in `Program.cs` from `.AddNpmApp` to `.AddViteApp` with `.WithNpmPackageInstallation()`.
- Modified `Port` property in `SwaResourceOptions.cs` to use a random port between 4280 and 5280.
- Updated tests in `SwaHostingComponentTests.cs` to utilize `CancellationToken` for better control over async operations.

Related Work Items: #6, #677
@aaronpowell aaronpowell linked an issue May 23, 2025 that may be closed by this pull request
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
CommunityToolkit.Aspire.EventStore 100% 100% 46
CommunityToolkit.Aspire.GoFeatureFlag 100% 97% 74
CommunityToolkit.Aspire.Hosting.ActiveMQ 80% 40% 100
CommunityToolkit.Aspire.Hosting.ActiveMQ.MassTransit 1% 0% 14
CommunityToolkit.Aspire.Hosting.Adminer 73% 50% 20
CommunityToolkit.Aspire.Hosting.Azure.Dapr 67% 50% 828
CommunityToolkit.Aspire.Hosting.Azure.Dapr.Redis 97% 88% 36
CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder 100% 100% 22
CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps 84% 50% 28
CommunityToolkit.Aspire.Hosting.Bun 82% 71% 54
CommunityToolkit.Aspire.Hosting.Dapr 63% 51% 724
CommunityToolkit.Aspire.Hosting.DbGate 94% 50% 18
CommunityToolkit.Aspire.Hosting.Deno 84% 75% 72
CommunityToolkit.Aspire.Hosting.EventStore 94% 100% 18
CommunityToolkit.Aspire.Hosting.GoFeatureFlag 93% 50% 18
CommunityToolkit.Aspire.Hosting.Golang 94% 50% 16
CommunityToolkit.Aspire.Hosting.Java 69% 72% 120
CommunityToolkit.Aspire.Hosting.k6 58% 12% 20
CommunityToolkit.Aspire.Hosting.LavinMQ 78% 50% 18
CommunityToolkit.Aspire.Hosting.LavinMQ.MassTransit 1% 0% 14
CommunityToolkit.Aspire.Hosting.MailPit 91% 50% 14
CommunityToolkit.Aspire.Hosting.Meilisearch 73% 57% 50
CommunityToolkit.Aspire.Hosting.MongoDB.Extensions 96% 83% 36
CommunityToolkit.Aspire.Hosting.MySql.Extensions 100% 94% 40
CommunityToolkit.Aspire.Hosting.Ngrok 52% 35% 82
CommunityToolkit.Aspire.Hosting.NodeJS.Extensions 90% 69% 96
CommunityToolkit.Aspire.Hosting.Ollama 67% 69% 162
CommunityToolkit.Aspire.Hosting.PapercutSmtp 92% 50% 10
CommunityToolkit.Aspire.Hosting.PostgreSQL.Extensions 98% 88% 92
CommunityToolkit.Aspire.Hosting.Python.Extensions 68% 55% 90
CommunityToolkit.Aspire.Hosting.RavenDB 63% 49% 136
CommunityToolkit.Aspire.Hosting.Redis.Extensions 100% 80% 40
CommunityToolkit.Aspire.Hosting.Rust 94% 83% 16
CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects 75% 62% 130
CommunityToolkit.Aspire.Hosting.Sqlite 97% 91% 54
CommunityToolkit.Aspire.Hosting.SqlServer.Extensions 100% 85% 76
CommunityToolkit.Aspire.MassTransit.RabbitMQ 100% 100% 30
CommunityToolkit.Aspire.Meilisearch 97% 92% 68
CommunityToolkit.Aspire.Microsoft.Data.Sqlite 37% 27% 194
CommunityToolkit.Aspire.Microsoft.EntityFrameworkCore.Sqlite 51% 50% 92
CommunityToolkit.Aspire.OllamaSharp 71% 64% 98
CommunityToolkit.Aspire.RavenDB.Client 60% 53% 237
Summary 71% (6474 / 9101) 58% (1993 / 3458) 4103

Minimum allowed line rate is 60%

@aaronpowell aaronpowell temporarily deployed to azure-artifacts May 24, 2025 21:19 — with GitHub Actions Inactive
@aaronpowell aaronpowell merged commit deab95f into main May 24, 2025
90 checks passed
@aaronpowell aaronpowell deleted the 677-swa-functional-tests-failed-repeatedly-in-linux-and-windows-1 branch May 24, 2025 21:34
@aaronpowell aaronpowell mentioned this pull request May 24, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SWA functional tests failed repeatedly in Linux and Windows

2 participants