-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GO Feature Flag hosting and client integrations #425
Implement GO Feature Flag hosting and client integrations #425
Conversation
2 questions @aaronpowell
I am using podman, so maybe this is related to the container runtime.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some inline comments and also needs tests.
src/CommunityToolkit.Aspire.GoFeatureFlag/GoFeatureFlagHealthCheck.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Hosting.GoFeatureFlag/GoFeatureFlagResource.cs
Outdated
Show resolved
Hide resolved
I'll try the branch when I have a moment (just got a bit of stuff on the backlog first) and see if I hit it, as I don't use podman.
Are there specific locations which we have to mount stuff into the container, it looks like from the docs, so it makes sense to provide a simple way to mount your YAML files without having to worry around what the target of the mounts are. A Data Volume is probably less needed since do you really need to persist stuff between container runs? |
https://gofeatureflag.org/docs/relay-proxy/configure-relay-proxy#configuration-file The configuration file can be located either in I am not sure to see what extension method to provide based on these information. The reasonable option would be to mount source folder to And yes, this only require a read-only volume. The files are static BUT you can export evaluated flags into your file system. So maybe that can be interesting after all. |
8daa2ec
to
9498942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the integration test, but it's almost good to go
tests/CommunityToolkit.Aspire.Hosting.GoFeatureFlag.Tests/AppHostTests.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.GoFeatureFlag.Tests/GoFeatureFlagFunctionalTests.cs
Outdated
Show resolved
Hide resolved
4866cd8
to
14280bd
Compare
Did you get the OTEL exporter to work? @aaronpowell |
🤦 I totally forgot I was meant to look into that. Let me create a bug and follow up |
Closes #<ISSUE_NUMBER>
PR Checklist
Other information
GO Feature Flag is a lightweight, open-source solution that provides a simple and complete feature flag implementation. It allows you to easily manage and control the release of new features in your applications.
This solution offers both a relay proxy as a container and client consumer SDKs (including a .NET one).
This PR introduces the following:
GoFeatureFlagProvider
Note: GO Feature Flag is affiliated with the Cloud Native Computing Foundation (CNCF) and adheres to the OpenFeature standard.