Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a NodeJS extensions pack #18

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Adding a NodeJS extensions pack #18

merged 6 commits into from
Sep 12, 2024

Conversation

aaronpowell
Copy link
Member

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@aaronpowell
Adding a NodeJS extensions pack
05aae7f 
- Defaults for running a vite app
- Support for running apps with pnpm and yarn
- Node package install support
- Tests + Sample + Docs
@aaronpowell
Some missing docs
9f683d4
@aaronpowell
checking if we have to run the setup pnpm step
a5b566c
@aaronpowell
have to specify a pnpm version
2146506
@aaronpowell
adjusting the text looked for in the logs
6d7fbca
@aaronpowell aaronpowell merged commit 399b7a0 into main Sep 12, 2024
8 checks passed
@aaronpowell aaronpowell deleted the node-extensions branch September 12, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aaronpowell