Refine SurrealDB hosting test coverage - #1441
Merged
Merged
Conversation
Move SurrealDB coverage to hosting public API tests, remove the old functional test file, and tighten assertions around mounts, health checks, init files, and creation scripts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1441Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1441" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the SurrealDB hosting integration’s test suite by moving coverage from Docker-based functional tests to unit/public-API tests that validate the Aspire resource model (annotations, mounts, init-file wiring, and creation scripts).
Changes:
- Added public API tests that assert health check annotation creation, container mount annotations, init-file container file wiring + env var, and creation-script annotations.
- Removed the previous Docker-driven
SurrealDbFunctionalTestssuite. - Updated test/project wiring by removing a direct compile-include and adding
InternalsVisibleTofor the tests.
Show a summary per file
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.SurrealDb.Tests/SurrealDbPublicApiTests.cs | Adds unit/public-API assertions for health checks, mounts, init-file wiring, and creation-script annotations. |
| tests/CommunityToolkit.Aspire.Hosting.SurrealDb.Tests/SurrealDbFunctionalTests.cs | Removes Docker-based functional tests in favor of model-level assertions. |
| tests/CommunityToolkit.Aspire.Hosting.SurrealDb.Tests/CommunityToolkit.Aspire.Hosting.SurrealDb.Tests.csproj | Removes direct source inclusion now that internals are exposed to the test assembly. |
| src/CommunityToolkit.Aspire.Hosting.SurrealDb/CommunityToolkit.Aspire.Hosting.SurrealDb.csproj | Adds InternalsVisibleTo for the test project to enable internal-model assertions. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Low
aaronpowell
temporarily deployed
to
azure-artifacts
June 29, 2026 07:46 — with
GitHub Actions
Inactive
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
aaronpowell
temporarily deployed
to
azure-artifacts
June 29, 2026 09:22 — with
GitHub Actions
Inactive
Member
Author
|
@Odonno turns out that you're not actually a member to be assigned review, even though you're the codeowner here 😅 Anyway, invited you and want to have a look over this |
Odonno
approved these changes
Jun 29, 2026
This was referenced Aug 25, 2026
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: N/A
Overview
Moves SurrealDB coverage into the hosting public API tests, removes the old functional test, and adds unit assertions for data mounts, health check registration, init-file wiring, and creation-script annotations.
PR Checklist
Other information
The init-file and creation-script checks are intentionally unit-level and assert the resource model rather than running the full container workflow.