Skip to content

feat: add dummy /status probe in metrics' module #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ltitanb merged 3 commits into from
Aug 22, 2024
Merged

feat: add dummy /status probe in metrics' module #94

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f914dc7
feat: add dummy /status probe in metrics' module
aimxhaisse Aug 22, 2024
cdfa15c
fix: lint
aimxhaisse Aug 22, 2024
55cdbe7
fix: address review comments
aimxhaisse Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions crates/metrics/src/provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ impl MetricsProvider {
pub async fn run(self) -> eyre::Result<()> {
info!("Starting metrics server on port {}", self.config.server_port);

let router =
axum::Router::new().route("/metrics", get(handle_metrics)).with_state(self.registry);
let router = axum::Router::new()
.route("/metrics", get(handle_metrics))
.route("/status", get(handle_status))
.with_state(self.registry);
let address = SocketAddr::from(([0, 0, 0, 0], self.config.server_port));
let listener = TcpListener::bind(&address).await?;

Expand All @@ -51,6 +53,12 @@ impl MetricsProvider {
}
}

async fn handle_status() -> Response {
trace!("Handling status request");

StatusCode::OK.into_response()
}

async fn handle_metrics(State(registry): State<Registry>) -> Response {
trace!("Handling metrics request");

Expand Down