Skip to content

warning for exposed port #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ltitanb merged 2 commits into from
Aug 12, 2024
Merged

warning for exposed port #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ea408e
warning for exposed port
Aug 12, 2024
facdbbd
fmt
Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions crates/cli/src/docker_init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ pub fn handle_docker_init(config_path: String, output_dir: String) -> Result<()>
let builder_events_port = 30000;
let mut builder_events_modules = Vec::new();

let mut exposed_ports_warn = Vec::new();

// setup pbs service
targets.push(PrometheusTargetConfig {
targets: vec![format!("cb_pbs:{metrics_port}")],
Expand Down Expand Up @@ -172,7 +174,8 @@ pub fn handle_docker_init(config_path: String, output_dir: String) -> Result<()>
let (k, v) = get_env_val(BUILDER_SERVER_ENV, &env);
pbs_envs.insert(k, v);
}

exposed_ports_warn
.push(format!("pbs has an exported port on {}", cb_config.pbs.pbs_config.port));
let pbs_service = Service {
container_name: Some("cb_pbs".to_owned()),
image: Some(cb_config.pbs.docker_image),
Expand Down Expand Up @@ -310,7 +313,7 @@ pub fn handle_docker_init(config_path: String, output_dir: String) -> Result<()>
name: None,
}),
);

exposed_ports_warn.push("prometheus has an exported port on 9090".to_string());
let prometheus_service = Service {
container_name: Some("cb_prometheus".to_owned()),
image: Some("prom/prometheus:latest".to_owned()),
Expand All @@ -324,6 +327,7 @@ pub fn handle_docker_init(config_path: String, output_dir: String) -> Result<()>
services.insert("cb_prometheus".to_owned(), Some(prometheus_service));

if cb_config.metrics.use_grafana {
exposed_ports_warn.push("grafana has an exported port on 3000".to_string());
let grafana_service = Service {
container_name: Some("cb_grafana".to_owned()),
image: Some("grafana/grafana:latest".to_owned()),
Expand All @@ -347,7 +351,7 @@ pub fn handle_docker_init(config_path: String, output_dir: String) -> Result<()>

services.insert("cb_grafana".to_owned(), Some(grafana_service));
}

exposed_ports_warn.push("cadvisor has an exported port on 8080".to_string());
services.insert(
"cb_cadvisor".to_owned(),
Some(Service {
Expand Down Expand Up @@ -377,6 +381,13 @@ pub fn handle_docker_init(config_path: String, output_dir: String) -> Result<()>
let compose_path = Path::new(&output_dir).join(CB_COMPOSE_FILE);
// TODO: check if file exists already and avoid overwriting
std::fs::write(&compose_path, compose_str)?;
if !exposed_ports_warn.is_empty() {
println!("\n");
for exposed_port in exposed_ports_warn {
println!("Warning: {}", exposed_port);
}
println!("\n");
}
println!("Compose file written to: {:?}", compose_path);

// write envs to .env file
Expand Down