Feat/metrics #4
Merged
Feat/metrics #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- main point of interest is the `crates/cli/src/lib.rs` where the metrics logic has been integrated with the dockerized launching of modules.
- for the relevant example `da_commit` module, visit https://github.com/LimeChain/da-commit-dockerized
- merge launcher: actually populate with sample JWTs (hardcoded for now) - `DockerMetricsCollector` needs refactor to work with a per-module JWT - fix TODOs in `examples/da_commit` - fix TODOs in `examples/custom_boost`
ltitanb
approved these changes
Jun 29, 2024
Collaborator
ltitanb
left a comment
ltitanb
left a comment
There was a problem hiding this comment.
Looks good, merging and adjusting changes in main directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the CB launcher of docker containers with a metrics server that reports metrics, metrics reporting SDK and docker-compose, that spawns containers for prometheus (polling the metrics server) and grafana web UI for visualization.