Add nonce and chain ID to signature requests #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he source" This reverts commit 58c6117.
Merged
ltitanb
reviewed
Aug 14, 2025
ltitanb
approved these changes
Aug 19, 2025
jclapis
force-pushed
the
augment-sign-requests
branch
from
2c70460 to
66913c3
Compare
ltitanb
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies signature requests (and the way signatures are generated) to include an optional nonce that signer modules can use if they want to, and Commit-Boost's chain ID, as part of the signature tree generation. It's a precursor to an update of #297 as a way to make signatures themselves more robust against replays for module developers.