feat(signer): add metrics #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltitanb
reviewed
Dec 6, 2024
Collaborator
ltitanb
left a comment
ltitanb
left a comment
There was a problem hiding this comment.
Looks good! Could you please post a screenshot of the dashboard here, also please re-export the dashboard for public use similar to https://github.com/Commit-Boost/commit-boost-client/blob/main/grafana/public_dashboard.json
ltitanb
approved these changes
Dec 9, 2024
ltitanb
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Add endpoints metrics * Add grafana dashboard * Add more stats to dashboard * Fix clippy * Fix doc comments * Make signer metrics function private * Export signer dashboard for public use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics to the signer module. New dashboard can be found in Grafana. Stats displayed are:
Close #13