Skip to content

ci: remove path filters from required workflows#1622

Merged
benceruleanlu merged 2 commits intomainfrom
fix/remove-debug-all-paths-ignore
Feb 25, 2026
Merged

ci: remove path filters from required workflows#1622
benceruleanlu merged 2 commits intomainfrom
fix/remove-debug-all-paths-ignore

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Feb 25, 2026

Summary

  • remove paths-ignore filters from Build - All Platforms workflow triggers in .github/workflows/debug_all.yml
  • remove paths-ignore filters from lint/typecheck workflow triggers in .github/workflows/ci.yaml
  • ensure required checks are always created for PRs and pushes to main, avoiding blocked merges due to missing check contexts

Testing

  • not run (workflow trigger-only change)

Summary by CodeRabbit

  • Chores
    • CI workflows adjusted to run for a broader set of changes, so builds trigger more often for affected files.
    • Concurrency behavior updated to cancel in-progress runs when new runs start, reducing duplicated work.
    • No user-facing impact expected.

┆Issue is synchronized with this Notion page by [Unito]

Copilot AI review requested due to automatic review settings February 25, 2026 21:47
@benceruleanlu benceruleanlu requested a review from a team as a code owner February 25, 2026 21:47
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 25, 2026
@socket-security
Copy link

socket-security bot commented Feb 25, 2026

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@comfy-pr-bot
Copy link
Member

Test Evidence Check

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.

You can add it by:

  • GitHub: Drag & drop media directly into the PR description
  • YouTube: Include a link to a short demo

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions “Build - All Platforms” workflow triggers so the required build checks are always created for pull requests targeting main, avoiding merges being blocked by missing required check contexts.

Changes:

  • Removed paths-ignore filters from the pull_request trigger.
  • Removed paths-ignore filters from the push trigger.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

📝 Walkthrough

Walkthrough

Removed path-based ignores from CI workflow triggers in two GitHub Actions files, causing workflows to run for previously-ignored path changes; also enabled concurrency cancellation for in-progress runs in the debug workflow.

Changes

Cohort / File(s) Summary
GitHub Actions — debug workflow
.github/workflows/debug_all.yml
Deleted paths-ignore entries from both pull_request and push triggers; added concurrency with cancel-in-progress: true.
GitHub Actions — CI workflow
.github/workflows/ci.yaml
Removed path-based trigger filtering (paths-ignore) from pull_request and push, so CI will run for those paths now.

Poem

🐰 I hopped through YAML lines tonight,
Removed the ignores, let CI take flight,
Canceling old runs when new ones start,
A tidy queue and a hopeful heart. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: remove path filters from required workflows' directly describes the main change: removing path-based filters from CI workflows to ensure required checks always run.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/remove-debug-all-paths-ignore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 25, 2026
@benceruleanlu benceruleanlu changed the title ci: remove path filters from build-all workflow ci: remove path filters from required workflows Feb 25, 2026
@benceruleanlu benceruleanlu merged commit 1af4e4f into main Feb 25, 2026
7 checks passed
@benceruleanlu benceruleanlu deleted the fix/remove-debug-all-paths-ignore branch February 25, 2026 22:42
benceruleanlu added a commit that referenced this pull request Feb 26, 2026
This FE bump has no code changes (on the FE side), just to have
desktop-dist.zip available

## Summary
- bump `config.frontend.version` in `package.json` from `1.39.17` to
`1.39.18`
- keep this PR scoped to the frontend version bump only

## Merge Order
- merge after #1622
- merge before #1619

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-1623-chore-bump-frontend-version-to-1-39-18-3126d73d365081e1880dd61b18dbca34)
by [Unito](https://www.unito.io)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
  * Version updated to 1.39.18

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants