Bump ComfyUI to v0.15.0 and frontend to v1.39.16 (package.json only)#1615
Bump ComfyUI to v0.15.0 and frontend to v1.39.16 (package.json only)#1615benceruleanlu wants to merge 1 commit intomainfrom
Conversation
📝 WalkthroughWalkthroughVersion bumps for frontend (1.38.14 to 1.39.16) and ComfyUI (0.14.2 to 0.15.0) dependencies are updated in the package configuration. Changes
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the ComfyUI and frontend version references in the electron desktop app's package.json configuration. These versions are used by build scripts to download the appropriate tagged releases from the respective repositories.
Changes:
- Bump ComfyUI version from 0.14.2 to 0.15.0
- Bump frontend version from 1.38.14 to 1.39.16
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 379ffd8efc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "config": { | ||
| "frontend": { | ||
| "version": "1.38.14", | ||
| "version": "1.39.16", |
There was a problem hiding this comment.
Keep requirements patch in sync with bumped core/frontend
Bumping config.frontend.version/config.comfyUI.version here without updating scripts/core-requirements.patch can break asset generation: scripts/makeComfy.js always runs yarn run patch:core:frontend, and that patch currently removes the exact line comfyui-frontend-package==1.38.14. If ComfyUI v0.15.0 now pins a different frontend package version (which this commit implies by moving to 1.39.16), scripts/patchComfyUI.js will fail to apply the patch and abort yarn make:assets in build workflows.
Useful? React with 👍 / 👎.
Summary
package.jsonconfig.comfyUI.versionfrom0.14.2to0.15.0package.jsonconfig.frontend.versionfrom1.38.14to1.39.16package.jsononlyTesting
yarn lintyarn typecheck┆Issue is synchronized with this Notion page by Unito
Summary by CodeRabbit