Skip to content

Revert "Update ComfyUI core to v0.9.1 (#1528)"#1533

Closed
benceruleanlu wants to merge 1 commit intomainfrom
revert-core-comfyui-0-9-1
Closed

Revert "Update ComfyUI core to v0.9.1 (#1528)"#1533
benceruleanlu wants to merge 1 commit intomainfrom
revert-core-comfyui-0-9-1

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Jan 15, 2026

Reverts the ComfyUI core bump to v0.9.1.

Reason: #1532

This is to unblock release that contains the PyPI mirror fallback

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu benceruleanlu requested a review from a team as a code owner January 15, 2026 08:24
Copilot AI review requested due to automatic review settings January 15, 2026 08:24
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Release labels Jan 15, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

Version pins for ComfyUI-related packages are downgraded across compiled requirement files for different platforms (macOS and Windows variants), configuration files, and patch scripts. Specific downgrades include comfyui-embedded-docs from 0.4.0 to 0.3.1, comfyui-workflow-templates from 0.8.4 to 0.7.69 (or 0.7.64 for Windows AMD), comfyui-frontend-package from 1.36.14 to 1.35.9, and ComfyUI version from 0.9.1 to 0.8.2.

Changes

Cohort / File(s) Summary
Platform-specific requirements
assets/requirements/macos.compiled, assets/requirements/windows_amd.compiled, assets/requirements/windows_cpu.compiled, assets/requirements/windows_nvidia.compiled
Downgrade comfyui-embedded-docs (0.4.0 → 0.3.1) and comfyui-workflow-templates (0.8.4 → 0.7.69 or 0.7.64) across all platform variants
Configuration and patching
package.json, scripts/core-requirements.patch
Update config.frontend.version (1.36.14 → 1.35.9) and config.comfyUI.version (0.9.1 → 0.8.2) in package.json; downgrade comfyui-frontend-package, comfyui-workflow-templates, and comfyui-embedded-docs in core requirements patch

Possibly related PRs



📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a5fcbb and 0c8807c.

📒 Files selected for processing (6)
  • assets/requirements/macos.compiled
  • assets/requirements/windows_amd.compiled
  • assets/requirements/windows_cpu.compiled
  • assets/requirements/windows_nvidia.compiled
  • package.json
  • scripts/core-requirements.patch
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Agent
  • GitHub Check: lint-and-format (macos-latest)
  • GitHub Check: lint-and-format (windows-latest)
  • GitHub Check: build-apple-debug-all / build-macos-debug
  • GitHub Check: build-and-test-e2e-windows / integration-windows-test
🔇 Additional comments (6)
assets/requirements/windows_cpu.compiled (1)

48-56: LGTM - version downgrades are consistent with the revert.

The downgrades to comfyui-embedded-docs (0.3.1) and comfyui-workflow-templates (0.7.69) align with the PR objective to revert the ComfyUI core bump.

assets/requirements/windows_nvidia.compiled (1)

49-56: LGTM - version downgrades are consistent across platforms.

The downgrades match the versions in windows_cpu.compiled, maintaining consistency across Windows platform variants.

package.json (1)

12-20: LGTM - core version configuration reverted correctly.

The frontend (1.35.9) and ComfyUI (0.8.2) versions are reverted to their pre-bump values, consistent with the PR objective.

assets/requirements/macos.compiled (1)

44-52: LGTM - macOS version downgrades are consistent.

The downgrades to comfyui-embedded-docs (0.3.1) and comfyui-workflow-templates (0.7.69) align with the other platform requirement files (except Windows AMD which uses 0.7.64).

assets/requirements/windows_amd.compiled (1)

48-56: Confirm intentional version difference for comfyui-workflow-templates in Windows AMD build.

The file pins comfyui-workflow-templates==0.7.64, while all other platforms (macos.compiled, windows_cpu.compiled, windows_nvidia.compiled) use 0.7.69. Verify this AMD-specific version difference is intentional—possibly due to ROCm/AMD torch compatibility constraints—or if it should be aligned with other platforms.

scripts/core-requirements.patch (1)

4-8: No action needed. This patch correctly removes comfyui-frontend-package==1.35.9 from ComfyUI's requirements.txt as part of reverting PR #1528. The desktop app manages the frontend version independently via package.json (currently pinned at version 1.35.9 in the config.frontend.version field), so this dependency is not needed in ComfyUI core's requirements.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/entities@4.5.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@4.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reverts the ComfyUI core version bump from v0.9.1 back to v0.8.2, effectively undoing PR #1528. This includes rolling back the frontend version from 1.36.14 to 1.35.9 and reverting associated package dependencies to their earlier versions.

Changes:

  • Reverted ComfyUI core version from 0.9.1 to 0.8.2 in package.json
  • Reverted frontend version from 1.36.14 to 1.35.9 in package.json
  • Rolled back dependency versions for comfyui-embedded-docs (0.4.0 → 0.3.1) and comfyui-workflow-templates (0.8.4 → 0.7.69) across all platform-specific requirement files

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Reverted comfyUI.version to 0.8.2 and frontend.version to 1.35.9
scripts/core-requirements.patch Updated patch file to reflect older package versions (comfyui-frontend-package 1.35.9, comfyui-workflow-templates 0.7.69, comfyui-embedded-docs 0.3.1)
assets/requirements/windows_nvidia.compiled Rolled back comfyui-embedded-docs and comfyui-workflow-templates versions
assets/requirements/windows_cpu.compiled Rolled back comfyui-embedded-docs and comfyui-workflow-templates versions
assets/requirements/windows_amd.compiled Rolled back comfyui-embedded-docs and comfyui-workflow-templates versions
assets/requirements/macos.compiled Rolled back comfyui-embedded-docs and comfyui-workflow-templates versions
Comments suppressed due to low confidence (7)

assets/requirements/windows_amd.compiled:26

  • The certifi package version contains a future date (2025.11.12, which is November 2025) when the current date is January 2026. This indicates the version doesn't exist yet or there's a typo in the version number. This should be corrected to use a valid, existing version.
certifi==2025.11.12

assets/requirements/windows_amd.compiled:91

  • The fsspec package version contains a future date (2025.12.0, which is December 2025) when the current date is January 2026. This indicates the version doesn't exist yet or there's a typo in the version number. This should be corrected to use a valid, existing version.
fsspec==2025.12.0

assets/requirements/windows_amd.compiled:5

  • The aiohappyeyeballs version 2.6.1 appears to be significantly higher than versions in other compiled files (e.g., 2.4.6 in windows_nvidia.compiled, 2.4.3 in macos.compiled). This may indicate a nonexistent or incorrect version. Please verify this version exists on PyPI.
aiohappyeyeballs==2.6.1

assets/requirements/windows_amd.compiled:8

  • The aiohttp version 3.13.2 appears to be significantly higher than versions in other compiled files (e.g., 3.11.12 in windows_nvidia.compiled, 3.11.18 in macos.compiled). This may indicate a nonexistent or incorrect version. Please verify this version exists on PyPI.
aiohttp==3.13.2

assets/requirements/windows_amd.compiled:23

  • The av version 16.0.1 appears to be significantly higher than versions in other compiled files (e.g., 14.2.0 in windows_nvidia.compiled, 14.3.0 in macos.compiled). This may indicate a nonexistent or incorrect version. Please verify this version exists on PyPI.
av==16.0.1

assets/requirements/windows_amd.compiled:29

  • The cffi version 2.0.0 appears to be significantly higher than versions in other compiled files (e.g., 1.17.1 in windows_nvidia.compiled and macos.compiled). This may indicate a nonexistent or incorrect version. Please verify this version exists on PyPI.
cffi==2.0.0

assets/requirements/windows_amd.compiled:72

  • The cryptography version 46.0.3 appears to be significantly higher than versions in other compiled files (e.g., 44.0.0 in windows_nvidia.compiled, 43.0.3 in macos.compiled). This may indicate a nonexistent or incorrect version. Please verify this version exists on PyPI.
cryptography==46.0.3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@benceruleanlu
Copy link
Member Author

Replaced by #1537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants