Conversation
dosubot
bot
added
the
size:L
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughSwitched ComfyUI Manager dependency source from the bundled custom_nodes path to Changes
Possibly related PRs
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
assets/requirements/macos.compiled(12 hunks)assets/requirements/windows_cpu.compiled(9 hunks)assets/requirements/windows_nvidia.compiled(12 hunks)package.json(3 hunks)scripts/core-requirements.patch(1 hunks)
🧰 Additional context used
🧠 Learnings (8)
📚 Learning: 2025-11-25T20:49:28.076Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.076Z
Learning: Applies to **/*.{ts,tsx} : Run `yarn typescript` to perform TypeScript type checking after making changes.
Applied to files:
package.json
📚 Learning: 2025-11-25T20:49:28.076Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.076Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Use ESLint and Prettier for code formatting and linting - run `yarn lint` and `yarn format` to ensure consistent code style.
Applied to files:
package.json
📚 Learning: 2025-11-25T20:49:28.076Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.076Z
Learning: Before committing, run `yarn format` to ensure consistent formatting, `yarn lint` and `yarn typescript` to check code quality, and `yarn test:unit` to ensure unit tests pass.
Applied to files:
package.json
📚 Learning: 2025-11-25T20:49:28.076Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.076Z
Learning: Applies to src/**/*.ts : Maintain the proper project structure with main process entry at `main.ts`, core application logic in `desktopApp.ts`, preload script at `preload.ts`, and organize modules in appropriate subdirectories (`main-process/`, `install/`, `handlers/`, `services/`, `config/`, `store/`, `utils.ts`).
Applied to files:
package.json
📚 Learning: 2025-11-25T20:50:25.371Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: .cursor/rules/vitest.mdc:0-0
Timestamp: 2025-11-25T20:50:25.371Z
Learning: Applies to tests/unit/**/*.test.{js,ts} : Use `vitest` for unit testing
Applied to files:
package.json
📚 Learning: 2025-11-25T20:49:28.076Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.076Z
Learning: Applies to **/*.{ts,tsx} : Follow existing TypeScript patterns in the codebase and maintain clean separation between main process, renderer, and preload scripts.
Applied to files:
package.json
📚 Learning: 2025-11-25T20:49:40.925Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: .cursor/rules/integration-testing.mdc:0-0
Timestamp: 2025-11-25T20:49:40.925Z
Learning: Organize integration tests using Playwright test projects: install, post-install-setup, post-install, and post-install-teardown
Applied to files:
package.json
📚 Learning: 2025-11-25T20:50:25.371Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: .cursor/rules/vitest.mdc:0-0
Timestamp: 2025-11-25T20:50:25.371Z
Learning: Applies to tests/unit/**/*.test.{js,ts} : Do not build custom testing infrastructure; use Vitest and existing helpers
Applied to files:
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Agent
- GitHub Check: build-apple-debug-all / build-macos-debug
- GitHub Check: build-and-test-e2e-windows / integration-windows-test
- GitHub Check: lint-and-format (windows-latest)
🔇 Additional comments (8)
scripts/core-requirements.patch (1)
5-6: Verify the removal ofcomfyui-frontend-packageis intentional.The patch removes
comfyui-frontend-package==1.34.9fromrequirements.txt. Ensure this is intentional and that the frontend package is now installed through an alternative mechanism (e.g., handled separately by the build process or viamanager_requirements.txt).package.json (1)
14-18: Version updates align with PR objectives.Frontend version updated to
1.34.9and ComfyUI version updated to0.5.0, consistent with the PR description.assets/requirements/windows_cpu.compiled (2)
51-53: Note:comfyui-manageris a beta version.The compiled requirements include
comfyui-manager==4.0.3b5, which is a beta release. Ensure this is intentional and tested for stability before release.
1-2: Manager requirements source updated correctly.The compile command now sources from
assets/ComfyUI/manager_requirements.txtinstead of the oldcustom_nodes/ComfyUI-Manager/requirements.txtpath, aligning with the new dependency resolution approach.assets/requirements/macos.compiled (2)
2-4: Verify cu129 extra-index-url is needed for macOS ARM.The macOS compilation includes
--extra-index-url https://download.pytorch.org/whl/cu129, but macOS ARM (aarch64-apple-darwin) doesn't use CUDA. Some packages (filelock, fsspec, numpy, pillow, etc.) are being pulled from this index. Verify this is intentional and doesn't cause issues on macOS.
47-67: Package updates consistent with other platforms.
comfyui-manager==4.0.3b5and workflow-templates packages are aligned with the Windows compiled requirements.assets/requirements/windows_nvidia.compiled (2)
1-2: Autogenerated requirements updated correctly.The compile command properly includes
manager_requirements.txtand uses the cu129 wheel index for Windows NVIDIA builds.
276-301: PyTorch 2.8.0 with CUDA 12.9 for Windows NVIDIA.The Windows NVIDIA build uses
torch==2.8.0+cu129, which is a significant version bump. Ensure compatibility testing has been performed with ComfyUI v0.5.0.
There was a problem hiding this comment.
Pull request overview
This PR updates ComfyUI core to v0.5.0, along with updating the frontend package to v1.34.9 and workflow templates to v0.7.59. The update includes dependency updates across all platform-specific compiled requirements files.
- Updated ComfyUI core version from v0.4.0 to v0.5.0
- Updated frontend from v1.33.14 to v1.34.9 and workflow templates from v0.7.54 to v0.7.59
- Refactored ComfyUI Manager integration from custom nodes to a proper Python package (
comfyui-manager==4.0.3b5)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated ComfyUI and frontend version configs; added duplicate lint:fix and typecheck scripts |
| scripts/core-requirements.patch | Updated patch file to reflect new frontend and template versions |
| assets/requirements/windows_nvidia.compiled | Updated compiled dependencies with new package versions; removed soundfile and matrix-client; added comfyui-manager package |
| assets/requirements/windows_cpu.compiled | Similar dependency updates as NVIDIA variant but for CPU-only Windows builds |
| assets/requirements/macos.compiled | Updated macOS dependencies; incorrectly includes CUDA-specific PyTorch index URL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # uv pip compile assets/ComfyUI/requirements.txt assets/ComfyUI/custom_nodes/ComfyUI-Manager/requirements.txt --emit-index-annotation --emit-index-url --index-strategy unsafe-best-match -o assets/requirements/macos.compiled --override assets/override.txt --index-url https://pypi.org/simple --index-url https://pypi.org/simple | ||
| # uv pip compile assets/ComfyUI/requirements.txt assets/ComfyUI/manager_requirements.txt --emit-index-annotation --emit-index-url --index-strategy unsafe-best-match --python-platform aarch64-apple-darwin --python-version 3.12 --override assets/override.txt --index-url https://pypi.org/simple -o assets/requirements/macos.compiled | ||
| --index-url https://pypi.org/simple | ||
| --extra-index-url https://download.pytorch.org/whl/cu129 |
There was a problem hiding this comment.
An extra index URL for PyTorch CUDA packages (https://download.pytorch.org/whl/cu129) has been added to the macOS requirements file. This is unusual since macOS builds typically use CPU-only or Metal GPU acceleration, not CUDA. This index URL should likely only be present in the Windows NVIDIA configuration, not in the macOS configuration.
| --extra-index-url https://download.pytorch.org/whl/cu129 |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (9)
📚 Learning: 2025-11-25T20:49:28.076Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.076Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Use ESLint and Prettier for code formatting and linting - run `yarn lint` and `yarn format` to ensure consistent code style.
Applied to files:
package.json
📚 Learning: 2025-11-25T20:49:28.076Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.076Z
Learning: Applies to **/*.{ts,tsx} : Run `yarn typescript` to perform TypeScript type checking after making changes.
Applied to files:
package.json
📚 Learning: 2025-11-25T20:49:28.076Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.076Z
Learning: Applies to **/*.{ts,tsx} : Follow existing TypeScript patterns in the codebase and maintain clean separation between main process, renderer, and preload scripts.
Applied to files:
package.json
📚 Learning: 2025-11-25T20:49:28.076Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.076Z
Learning: Before committing, run `yarn format` to ensure consistent formatting, `yarn lint` and `yarn typescript` to check code quality, and `yarn test:unit` to ensure unit tests pass.
Applied to files:
package.json
📚 Learning: 2025-11-25T20:50:17.635Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-11-25T20:50:17.635Z
Learning: Applies to **/*.{ts,mts,cts} : Keep files focused and cohesive. Extract helpers when a module exceeds a clear single responsibility
Applied to files:
package.json
📚 Learning: 2025-11-25T20:50:17.635Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-11-25T20:50:17.635Z
Learning: Applies to **/*.{ts,mts,cts} : Use descriptive, intention-revealing names. Avoid abbreviations. Classes/types use `PascalCase`; variables/functions use `camelCase`
Applied to files:
package.json
📚 Learning: 2025-11-25T20:50:17.635Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-11-25T20:50:17.635Z
Learning: Applies to **/*.{ts,mts,cts} : Use `import type { X } from '…'` for type-only imports. Keep value and type imports separated when helpful for clarity and bundling
Applied to files:
package.json
📚 Learning: 2025-11-25T20:50:17.635Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-11-25T20:50:17.635Z
Learning: Applies to **/*.{ts,mts,cts} : Use features available in TypeScript 5.x
Applied to files:
package.json
📚 Learning: 2025-11-25T20:49:28.076Z
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.076Z
Learning: Applies to **/*.{ts,tsx} : Use TypeScript as the primary language and maintain exceptionally high type standards - the `any` type must not be used. `unknown` can be used when the type is unknown.
Applied to files:
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build-and-test-e2e-windows / integration-windows-test
- GitHub Check: build-apple-debug-all / build-macos-debug
- GitHub Check: lint-and-format (windows-latest)
Updated versions
┆Issue is synchronized with this Notion page by Unito