[backport core/1.41] Use preview downscaling in fewer places#9682
Merged
AustinMroz merged 1 commit intocore/1.41from Mar 9, 2026
Merged
[backport core/1.41] Use preview downscaling in fewer places#9682AustinMroz merged 1 commit intocore/1.41from
AustinMroz merged 1 commit intocore/1.41from
Conversation
Thumbnail downscaling is currently being used in more places than it should be. - Nodes which display images will display incorrect resolution indicators <img width="255" height="372" alt="image" src="https://github.com/user-attachments/assets/674790b6-04c8-4db0-84c2-2fa2dbaf123d" /> <img width="255" height="372" alt="image" src="https://github.com/user-attachments/assets/1dbe751b-7462-4408-9236-9446b005f5fc" /> This is particularly confusing with output nodes, which claim the output is not of the intended resolution - The "Download Image" and "Open Image" context menu actions will incorrectly download the downscaled thumbnail. - The assets panel will incorrectly display the thumbnail resolution as the resolution of the output - The lightbox (zoom) of an image will incorrectly display a downscaled thumbnail. This PR is a quick workaround to staunch the major problems - Nodes always display full previews. - Resolution downscaling is applied on the assert card, not on the assetItem itself - Due to implementation, this means that asset cards will still incorrectly show the resolution of the thumbnail instead of the size of the full image. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
dosubot
bot
added
the
size:S
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 548 passed, 0 failed · 6 flaky📊 Browser Reports
|
AustinMroz
approved these changes
Mar 9, 2026
⚡ Performance Report
Raw data{
"timestamp": "2026-03-09T23:08:52.183Z",
"gitSha": "0694889cf5d57e1c9354d923449a090c88c49437",
"branch": "backport-9678-to-core-1.41",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2012.9809999999964,
"styleRecalcs": 123,
"styleRecalcDurationMs": 21.142,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.966,
"heapDeltaBytes": -3591908
},
{
"name": "canvas-idle",
"durationMs": 2030.9819999999945,
"styleRecalcs": 124,
"styleRecalcDurationMs": 17.283,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.71,
"heapDeltaBytes": -3379852
},
{
"name": "canvas-idle",
"durationMs": 2011.8810000000167,
"styleRecalcs": 122,
"styleRecalcDurationMs": 17.826,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.21799999999996,
"heapDeltaBytes": -2897264
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2039.3550000000005,
"styleRecalcs": 183,
"styleRecalcDurationMs": 55.324999999999996,
"layouts": 12,
"layoutDurationMs": 3.5380000000000003,
"taskDurationMs": 1060.657,
"heapDeltaBytes": -3091376
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1848.0010000000107,
"styleRecalcs": 165,
"styleRecalcDurationMs": 41.818,
"layouts": 12,
"layoutDurationMs": 3.0970000000000004,
"taskDurationMs": 812.118,
"heapDeltaBytes": -3242196
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.1230000000023,
"styleRecalcs": 159,
"styleRecalcDurationMs": 43.278999999999996,
"layouts": 13,
"layoutDurationMs": 3.0309999999999997,
"taskDurationMs": 754.3910000000001,
"heapDeltaBytes": -3453788
},
{
"name": "dom-widget-clipping",
"durationMs": 598.9299999999957,
"styleRecalcs": 42,
"styleRecalcDurationMs": 12.884,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.534,
"heapDeltaBytes": 7601772
},
{
"name": "dom-widget-clipping",
"durationMs": 551.7220000000407,
"styleRecalcs": 41,
"styleRecalcDurationMs": 12.297999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.734,
"heapDeltaBytes": 7510852
},
{
"name": "dom-widget-clipping",
"durationMs": 599.5290000000182,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.677,
"layouts": 1,
"layoutDurationMs": 0.26199999999999996,
"taskDurationMs": 383.045,
"heapDeltaBytes": 13694684
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.5999999999804,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.144000000000002,
"layouts": 1,
"layoutDurationMs": 0.28700000000000003,
"taskDurationMs": 404.78400000000005,
"heapDeltaBytes": 16511584
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.3300000000177,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.187000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.877,
"heapDeltaBytes": 15360012
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 569.7270000000003,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.39,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.06,
"heapDeltaBytes": 14664084
},
{
"name": "subgraph-idle",
"durationMs": 1991.3099999999986,
"styleRecalcs": 120,
"styleRecalcDurationMs": 18.206,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.27000000000004,
"heapDeltaBytes": -4147100
},
{
"name": "subgraph-idle",
"durationMs": 2005.7519999999727,
"styleRecalcs": 121,
"styleRecalcDurationMs": 20.981999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.492,
"heapDeltaBytes": -4730628
},
{
"name": "subgraph-idle",
"durationMs": 2006.4360000000079,
"styleRecalcs": 122,
"styleRecalcDurationMs": 22.556,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.58400000000006,
"heapDeltaBytes": -4327432
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.529000000017,
"styleRecalcs": 154,
"styleRecalcDurationMs": 44.381,
"layouts": 16,
"layoutDurationMs": 3.8470000000000004,
"taskDurationMs": 686.297,
"heapDeltaBytes": -5143620
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.9909999999463,
"styleRecalcs": 157,
"styleRecalcDurationMs": 41.535000000000004,
"layouts": 16,
"layoutDurationMs": 3.648,
"taskDurationMs": 692.55,
"heapDeltaBytes": -5280924
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1979.703000000029,
"styleRecalcs": 170,
"styleRecalcDurationMs": 48.20399999999999,
"layouts": 16,
"layoutDurationMs": 4.024,
"taskDurationMs": 927.9280000000001,
"heapDeltaBytes": -5128824
}
]
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9678 to
core/1.41Automatically created by backport workflow.
┆Issue is synchronized with this Notion page by Unito