[backport core/1.41] Restore hiding of linked inputs in app mode#9676
Merged
AustinMroz merged 1 commit intocore/1.41from Mar 9, 2026
Merged
[backport core/1.41] Restore hiding of linked inputs in app mode#9676AustinMroz merged 1 commit intocore/1.41from
AustinMroz merged 1 commit intocore/1.41from
Conversation
As a temporary fix for widgets being incorrectly hidden, #9669 allowed all disabled widgets to be displayed. This PR provides a more robust implementation to derive whether the widget, as would be displayed from the root graph, is disabled. Potential regression: - Drag drop handlers are applied on node, not widgets. A subgraph containing a "Load Image" node, does not allow dragging and dropping an image onto the subgraphNode in order to load it. Because app mode widgets would display from the original owning node prior to this PR, these drag/drop handlers would apply. Placing "Load Image" nodes. I believe this change makes behavior more consistent, but it warrants consideration. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9671-Restore-hiding-of-linked-inputs-in-app-mode-31e6d73d365081688e37fbb931f3af68) by [Unito](https://www.unito.io)
dosubot
bot
added
the
size:M
🎭 Playwright: ✅ 556 passed, 0 failed · 2 flaky📊 Browser Reports
|
🎨 Storybook: ✅ Built — View Storybook |
AustinMroz
approved these changes
Mar 9, 2026
DrJKL
approved these changes
Mar 9, 2026
⚡ Performance Report
Raw data{
"timestamp": "2026-03-09T20:30:57.581Z",
"gitSha": "92b362db9492bef3dd8710b251f14908bd56b25f",
"branch": "backport-9671-to-core-1.41",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.7629999999936,
"styleRecalcs": 124,
"styleRecalcDurationMs": 18.693,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.556,
"heapDeltaBytes": -3819748
},
{
"name": "canvas-idle",
"durationMs": 2029.2719999999917,
"styleRecalcs": 124,
"styleRecalcDurationMs": 19.636,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.08699999999993,
"heapDeltaBytes": -4192684
},
{
"name": "canvas-idle",
"durationMs": 2012.6010000000178,
"styleRecalcs": 123,
"styleRecalcDurationMs": 19.424999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.164,
"heapDeltaBytes": -4266324
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2060.6190000000024,
"styleRecalcs": 184,
"styleRecalcDurationMs": 54.905,
"layouts": 12,
"layoutDurationMs": 3.5599999999999996,
"taskDurationMs": 1054.656,
"heapDeltaBytes": -3933200
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2030.5979999999977,
"styleRecalcs": 181,
"styleRecalcDurationMs": 47.72,
"layouts": 12,
"layoutDurationMs": 3.2980000000000005,
"taskDurationMs": 999.1970000000001,
"heapDeltaBytes": -2944144
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2012.0400000000132,
"styleRecalcs": 180,
"styleRecalcDurationMs": 46.665,
"layouts": 12,
"layoutDurationMs": 2.9970000000000003,
"taskDurationMs": 992.4920000000001,
"heapDeltaBytes": -3998332
},
{
"name": "dom-widget-clipping",
"durationMs": 625.3799999999785,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.793,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.69,
"heapDeltaBytes": 7576952
},
{
"name": "dom-widget-clipping",
"durationMs": 548.0640000000108,
"styleRecalcs": 41,
"styleRecalcDurationMs": 12.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.132,
"heapDeltaBytes": 7638848
},
{
"name": "dom-widget-clipping",
"durationMs": 608.5399999999481,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.379999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.78999999999996,
"heapDeltaBytes": 7402580
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.6720000000314,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.611,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.04400000000004,
"heapDeltaBytes": 15436880
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.1409999999883,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.912999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.661,
"heapDeltaBytes": 14678212
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 663.0040000000008,
"styleRecalcs": 79,
"styleRecalcDurationMs": 20.659999999999997,
"layouts": 1,
"layoutDurationMs": 0.2930000000000001,
"taskDurationMs": 444.38800000000003,
"heapDeltaBytes": 15925020
},
{
"name": "subgraph-idle",
"durationMs": 1997.4980000000073,
"styleRecalcs": 121,
"styleRecalcDurationMs": 19.794000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.9170000000001,
"heapDeltaBytes": -3769056
},
{
"name": "subgraph-idle",
"durationMs": 1995.1650000000427,
"styleRecalcs": 121,
"styleRecalcDurationMs": 17.837,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.759,
"heapDeltaBytes": -4677012
},
{
"name": "subgraph-idle",
"durationMs": 1995.0840000000198,
"styleRecalcs": 120,
"styleRecalcDurationMs": 18.319000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.787,
"heapDeltaBytes": -3731688
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.6320000000374,
"styleRecalcs": 156,
"styleRecalcDurationMs": 49.717,
"layouts": 16,
"layoutDurationMs": 4.011000000000001,
"taskDurationMs": 807.852,
"heapDeltaBytes": -6521788
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1989.4770000000221,
"styleRecalcs": 172,
"styleRecalcDurationMs": 49.43300000000001,
"layouts": 16,
"layoutDurationMs": 4.772,
"taskDurationMs": 942.7289999999999,
"heapDeltaBytes": -5103624
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.4119999999775,
"styleRecalcs": 157,
"styleRecalcDurationMs": 51.522,
"layouts": 16,
"layoutDurationMs": 4.535,
"taskDurationMs": 803.549,
"heapDeltaBytes": -5311712
}
]
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9671 to
core/1.41Automatically created by backport workflow.
┆Issue is synchronized with this Notion page by Unito