[backport core/1.41] Always use interior nodeId for app mode#9674
Merged
AustinMroz merged 1 commit intocore/1.41from Mar 9, 2026
Merged
[backport core/1.41] Always use interior nodeId for app mode#9674AustinMroz merged 1 commit intocore/1.41from
AustinMroz merged 1 commit intocore/1.41from
Conversation
App mode stores the state of selected widgets as a tuple of `[NodeId, WidgetName]`. With recent subgraph changes, for a given node, `widget.name` will no longer uniquely resolve to a single widget. - From both Vue and Litegraph, selecting an input for display in App mode will now resolve the NodeId of the node which owns the widget instead of the selected node. - When displaying selections in litegraph, if the NodeId does not exist in the current graph, instead of resolving the actual node the rootGraph is searched for any subgraphNode which contains a view matching the `[NodeId, WidgetName]` pair. - When displaying widgets in App mode, the widget is always set as being a view of the real widget (This means that they will not display a purple promotion border. Known Issue: - These same subgraph changes made it so that a widget can be linked without being disabled. This PR makes it so widgets which have been linked instead display normally under the assumption that they are incorrectly marked as disabled. As disabled widgets can not be selected as inputs, this should handle normal usage fine, but a better solution is being investigated ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9669-Always-use-interior-nodeId-for-app-mode-31e6d73d365081f8a918d0e43cb659ee) by [Unito](https://www.unito.io)
dosubot
bot
added
the
size:M
DrJKL
approved these changes
Mar 9, 2026
🎭 Playwright: ✅ 556 passed, 0 failed · 2 flaky📊 Browser Reports
|
🎨 Storybook: ✅ Built — View Storybook |
⚡ Performance Report
Raw data{
"timestamp": "2026-03-09T20:21:48.804Z",
"gitSha": "48a1a1d01da210b84babdc7dbb87e1d078198833",
"branch": "backport-9669-to-core-1.41",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2065.2410000000145,
"styleRecalcs": 126,
"styleRecalcDurationMs": 25.603,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.70700000000005,
"heapDeltaBytes": -3374668
},
{
"name": "canvas-idle",
"durationMs": 2048.9130000000273,
"styleRecalcs": 127,
"styleRecalcDurationMs": 28.168,
"layouts": 1,
"layoutDurationMs": 0.24399999999999997,
"taskDurationMs": 454.98900000000003,
"heapDeltaBytes": -3442388
},
{
"name": "canvas-idle",
"durationMs": 2058.4069999999883,
"styleRecalcs": 126,
"styleRecalcDurationMs": 23.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.169,
"heapDeltaBytes": -3591980
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2122.598000000011,
"styleRecalcs": 190,
"styleRecalcDurationMs": 63.36600000000001,
"layouts": 12,
"layoutDurationMs": 3.503,
"taskDurationMs": 1202.647,
"heapDeltaBytes": -2739912
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2081.6520000000196,
"styleRecalcs": 184,
"styleRecalcDurationMs": 57.664,
"layouts": 12,
"layoutDurationMs": 3.4499999999999997,
"taskDurationMs": 1067.627,
"heapDeltaBytes": -3361356
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1892.3460000000318,
"styleRecalcs": 173,
"styleRecalcDurationMs": 49.578,
"layouts": 12,
"layoutDurationMs": 3.5420000000000003,
"taskDurationMs": 833.2299999999999,
"heapDeltaBytes": -3912816
},
{
"name": "dom-widget-clipping",
"durationMs": 587.050000000005,
"styleRecalcs": 42,
"styleRecalcDurationMs": 13.839,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.91599999999994,
"heapDeltaBytes": 7432076
},
{
"name": "dom-widget-clipping",
"durationMs": 575.1000000000204,
"styleRecalcs": 44,
"styleRecalcDurationMs": 16.730999999999998,
"layouts": 1,
"layoutDurationMs": 0.268,
"taskDurationMs": 364.12699999999995,
"heapDeltaBytes": 8268516
},
{
"name": "dom-widget-clipping",
"durationMs": 591.8360000000007,
"styleRecalcs": 42,
"styleRecalcDurationMs": 13.725999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.11899999999997,
"heapDeltaBytes": 6522492
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.0059999999607,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.632,
"layouts": 1,
"layoutDurationMs": 0.17900000000000013,
"taskDurationMs": 443.195,
"heapDeltaBytes": -8320308
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 617.1829999999545,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.503000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.04,
"heapDeltaBytes": -8885400
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.7450000000181,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.717999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.47600000000006,
"heapDeltaBytes": 15568984
},
{
"name": "subgraph-idle",
"durationMs": 2007.758999999993,
"styleRecalcs": 121,
"styleRecalcDurationMs": 25.801,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.87800000000004,
"heapDeltaBytes": -3436208
},
{
"name": "subgraph-idle",
"durationMs": 2010.4910000000018,
"styleRecalcs": 121,
"styleRecalcDurationMs": 24.676999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.589,
"heapDeltaBytes": -3705376
},
{
"name": "subgraph-idle",
"durationMs": 2010.4550000000359,
"styleRecalcs": 121,
"styleRecalcDurationMs": 23.269,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.845,
"heapDeltaBytes": -4337136
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.8369999999973,
"styleRecalcs": 154,
"styleRecalcDurationMs": 46.425999999999995,
"layouts": 16,
"layoutDurationMs": 4.087,
"taskDurationMs": 763.688,
"heapDeltaBytes": -5157400
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1992.5039999999967,
"styleRecalcs": 172,
"styleRecalcDurationMs": 56.056000000000004,
"layouts": 16,
"layoutDurationMs": 4.252000000000001,
"taskDurationMs": 991.6539999999999,
"heapDeltaBytes": -5141412
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.0180000000382,
"styleRecalcs": 155,
"styleRecalcDurationMs": 47.019,
"layouts": 16,
"layoutDurationMs": 4.64,
"taskDurationMs": 748.3340000000001,
"heapDeltaBytes": -6389104
}
]
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9669 to
core/1.41Automatically created by backport workflow.
┆Issue is synchronized with this Notion page by Unito