[backport cloud/1.41] fix: show load widget inputs in media dropdown#9673
Merged
DrJKL merged 1 commit intocloud/1.41from Mar 9, 2026
Merged
[backport cloud/1.41] fix: show load widget inputs in media dropdown#9673DrJKL merged 1 commit intocloud/1.41from
DrJKL merged 1 commit intocloud/1.41from
Conversation
Main targeted, built on #9551 ## Summary Fix Load Image/Load Video input dropdown tabs not showing available input assets in Vue node select dropdown. ## Changes - **What**: Keep combo widget `options` object identity while exposing dynamic `values` for cloud/remote combos. - **What**: Remove temporary debug logging and restore clearer dropdown filter branching. - **What**: Remove stale `searcher`/`updateKey` prop plumbing in dropdown menu/actions and update related tests. ## Review Focus Verify `Load Image` / `Load Video` Inputs tab behavior and confirm cloud/remote combo option values still update correctly. Relates to #9551 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9670-fix-show-load-widget-inputs-in-media-dropdown-31e6d73d36508148b845e18268a60c2a) by [Unito](https://www.unito.io) --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
dosubot
bot
added
the
size:L
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 558 passed, 0 failed · 1 flaky📊 Browser Reports
|
DrJKL
approved these changes
Mar 9, 2026
⚡ Performance ReportNo baseline found — showing absolute values.
Raw data{
"timestamp": "2026-03-09T19:55:57.538Z",
"gitSha": "9462061dc75c43d415b0f8ec2ae9a47a2d9117f4",
"branch": "backport-9670-to-cloud-1.41",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.207000000008,
"styleRecalcs": 122,
"styleRecalcDurationMs": 17.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.674,
"heapDeltaBytes": -3623604
},
{
"name": "canvas-idle",
"durationMs": 2044.144000000017,
"styleRecalcs": 125,
"styleRecalcDurationMs": 17.404,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.51300000000003,
"heapDeltaBytes": -3579556
},
{
"name": "canvas-idle",
"durationMs": 2014.6110000000022,
"styleRecalcs": 123,
"styleRecalcDurationMs": 17.194999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.698,
"heapDeltaBytes": -3348060
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2013.2380000000012,
"styleRecalcs": 181,
"styleRecalcDurationMs": 47.269,
"layouts": 12,
"layoutDurationMs": 3.3579999999999997,
"taskDurationMs": 1002.8,
"heapDeltaBytes": -3114608
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.7330000000456,
"styleRecalcs": 162,
"styleRecalcDurationMs": 40.113,
"layouts": 12,
"layoutDurationMs": 3.067,
"taskDurationMs": 777.423,
"heapDeltaBytes": -3815796
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2031.5749999999753,
"styleRecalcs": 180,
"styleRecalcDurationMs": 44.1,
"layouts": 12,
"layoutDurationMs": 3.1029999999999998,
"taskDurationMs": 971.827,
"heapDeltaBytes": -3387024
},
{
"name": "dom-widget-clipping",
"durationMs": 575.9519999999725,
"styleRecalcs": 42,
"styleRecalcDurationMs": 12.037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.994,
"heapDeltaBytes": 7250604
},
{
"name": "dom-widget-clipping",
"durationMs": 586.593999999991,
"styleRecalcs": 43,
"styleRecalcDurationMs": 16.084,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.19700000000006,
"heapDeltaBytes": 7711784
},
{
"name": "dom-widget-clipping",
"durationMs": 564.1289999999799,
"styleRecalcs": 41,
"styleRecalcDurationMs": 12.182,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.342,
"heapDeltaBytes": 7577932
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.6910000000207,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.304,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.212,
"heapDeltaBytes": 15588400
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.9460000000258,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.391,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.011,
"heapDeltaBytes": 15531176
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.018000000005,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.212000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.87000000000006,
"heapDeltaBytes": -8926856
},
{
"name": "subgraph-idle",
"durationMs": 2005.363999999986,
"styleRecalcs": 121,
"styleRecalcDurationMs": 16.865,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.992,
"heapDeltaBytes": -3404488
},
{
"name": "subgraph-idle",
"durationMs": 2005.219000000011,
"styleRecalcs": 121,
"styleRecalcDurationMs": 17.569000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.226,
"heapDeltaBytes": -3384084
},
{
"name": "subgraph-idle",
"durationMs": 1996.6389999999592,
"styleRecalcs": 120,
"styleRecalcDurationMs": 17.279000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.82599999999996,
"heapDeltaBytes": -3405796
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.9259999999813,
"styleRecalcs": 157,
"styleRecalcDurationMs": 44.763999999999996,
"layouts": 17,
"layoutDurationMs": 4.489,
"taskDurationMs": 703.347,
"heapDeltaBytes": -4500492
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.3750000000082,
"styleRecalcs": 155,
"styleRecalcDurationMs": 41.121,
"layouts": 16,
"layoutDurationMs": 4.432,
"taskDurationMs": 690.593,
"heapDeltaBytes": -5201724
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1964.1509999999585,
"styleRecalcs": 170,
"styleRecalcDurationMs": 45.422000000000004,
"layouts": 16,
"layoutDurationMs": 3.8490000000000006,
"taskDurationMs": 910.458,
"heapDeltaBytes": -5103008
}
]
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9670 to
cloud/1.41Automatically created by backport workflow.
┆Issue is synchronized with this Notion page by Unito