Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group node tests teardown #965

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix group node tests teardown #965

merged 1 commit into from
Sep 25, 2024

Conversation

christian-byrne
Copy link
Collaborator

Tests added in #950 were unsuccessfully trying to reset state in individual test blocks. Moved teardown logic to afterEach.

@christian-byrne
Copy link
Collaborator Author

Model is not downloading in test env:

    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: locator('.download-complete')
    Expected: visible
    Received: <element(s) not found>
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for locator('.download-complete')


      102 |     // Wait for the element with the .download-complete selector to be visible
      103 |     const downloadComplete = comfyPage.page.locator('.download-complete')
    > 104 |     await expect(downloadComplete).toBeVisible()
          |                                    ^
      105 |   })
      106 | })
      107 |

        at /home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/browser_tests/dialog.spec.ts:104:36

Works for me locally.

@huchenlei
Copy link
Member

Failing tests are regressed by ComfyUI main repo's change.

@huchenlei huchenlei merged commit 941f71f into main Sep 25, 2024
6 of 9 checks passed
@huchenlei huchenlei deleted the fix-groupnode-test branch September 25, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants