[backport core/1.40] fix: textarea stays disabled after link disconnect on promoted widgets (#9199)#9577
Conversation
#9199) Fix textarea widgets staying disabled after disconnecting a link on promoted widgets in subgraphs. - **What**: `refreshNodeSlots` used `SafeWidgetData.name` for slot metadata lookups, but for promoted widgets this is `sourceWidgetName` (the interior widget name), which doesn't match the subgraph node's input slot widget name. Added `slotName` field to `SafeWidgetData` to track the original LiteGraph widget name, and updated `refreshNodeSlots` to use `slotName ?? name` for correct matching. The key change is the `slotName` field on `SafeWidgetData` — it's only populated when `name !== widget.name` (i.e., for promoted widgets). The `refreshNodeSlots` function now uses `widget.slotName ?? widget.name` to look up slot metadata, ensuring promoted widgets correctly update their `linked` state on disconnect. Fixes #8818 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9199-fix-textarea-stays-disabled-after-link-disconnect-on-promoted-widgets-3126d73d3650813db499c227e6587aca) by [Unito](https://www.unito.io)
dosubot
bot
added
the
size:L
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 03/08/2026, 02:29:43 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Playwright: 🕵🏻 0 passed, 0 failed 📊 Browser Reports
|
1 participant
Backport of #9199 to core/1.40.
Conflicts resolved in useGraphNodeManager.ts/test.ts — accepted incoming promoted widget handling changes.
Original PR: #9199
Pipeline ticket: 15e1f241-efaa-4fe5-88ca-4ccc7bfb3345
┆Issue is synchronized with this Notion page by Unito