Skip to content

[backport core/1.40] fix: prevent persistent loading state when cycling batches with identical URLs#9570

Merged
christian-byrne merged 1 commit intocore/1.40from
backport-8999-to-core-1.40
Mar 8, 2026
Merged

[backport core/1.40] fix: prevent persistent loading state when cycling batches with identical URLs#9570
christian-byrne merged 1 commit intocore/1.40from
backport-8999-to-core-1.40

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Mar 8, 2026 •
edited by sync-by-unito bot
Loading

Backport of #8999 to core/1.40

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne @simula-r @github-actions
fix: prevent persistent loading state when cycling batches with ident…
3fe1427 
…ical URLs (#8999)

## Summary

Fix persistent loading/skeleton state when cycling through batch images
or videos that share the same URL (common on Cloud).

## Changes

- **What**: In `setCurrentIndex()` for both `ImagePreview.vue` and
`VideoPreview.vue`, only start the loader when the target URL differs
from the current URL. When batch items share the same URL, the browser
doesn't fire a new `load`/`loadeddata` event since `src` didn't change,
so the loader was never dismissed.
- Also fixes `VideoPreview.vue` navigation dots using hardcoded
`bg-white` instead of semantic `bg-base-foreground` tokens.

## Review Focus

This bug has regressed 3+ times (PRs #6521, #7094, #8366). The
regression tests specifically target the root cause — cycling through
identical URLs — to prevent future reintroduction.

Fixes
https://www.notion.so/comfy-org/Bug-Cycling-through-image-batches-results-in-persistent-loading-state-on-Cloud-30c6d73d3650816e9738d5dbea52c47d

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8999-fix-prevent-persistent-loading-state-when-cycling-batches-with-identical-URLs-30d6d73d36508180831edbaf8ad8ad48)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Simula_r <18093452+simula-r@users.noreply.github.com>
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner March 8, 2026 02:21
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Mar 8, 2026
@comfy-pr-bot comfy-pr-bot mentioned this pull request Mar 8, 2026
Merged
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 8, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0a0a4c77-28da-44af-9463-f53532f3ed2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-8999-to-core-1.40

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Mar 8, 2026 •
edited
Loading

Playwright: ✅ 528 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 515 / ❌ 0 / ⚠️ 3 / ⏭️ 10)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 10 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions
Copy link

github-actions bot commented Mar 8, 2026 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 03/08/2026, 02:22:37 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@christian-byrne christian-byrne merged commit 69aa9ae into core/1.40 Mar 8, 2026
32 checks passed
@christian-byrne christian-byrne deleted the backport-8999-to-core-1.40 branch March 8, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@comfy-pr-bot @christian-byrne