[backport cloud/1.40] fix: stabilize nested subgraph promoted widget resolution#9444
[backport cloud/1.40] fix: stabilize nested subgraph promoted widget resolution#9444DrJKL wants to merge 6 commits intocloud/1.40from
Conversation
…8995) The browser tests added in #8143 were failing on main because they were written against stale `ComfyPage` APIs that were refactored in #8510 (merged Feb 3, before #8143 merged Feb 18). ### Changes - `comfyPage.dragAndDropFile` → `comfyPage.dragDrop.dragAndDropFile` - `comfyPage.setSetting` → `comfyPage.settings.setSetting` - `comfyPage.loadWorkflow` → `comfyPage.workflow.loadWorkflow` - `comfyPage.getNodeRefsByType` → `comfyPage.nodeOps.getNodeRefsByType` - Fix `comfyPage` type parameter to use `ComfyPage` import - Remove `test.fixme` since root cause was API mismatch, not test logic ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8995-fix-update-imagePreview-browser-tests-to-use-current-fixture-APIs-30d6d73d365081219c1eda4ea7251160) by [Unito](https://www.unito.io)
) Amp-Thread-ID: https://ampcode.com/threads/T-019cbfdf-bf82-76de-b36c-91758530a0ce Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019cbfdf-bf82-76de-b36c-91758530a0ce Co-authored-by: Amp <amp@ampcode.com>
- Add svgBitmapCache.ts from #9172 (dependency of #9282) - Update drawImage to use workflowBitmapCache - Fix getWidget 3-arg signature in domWidget.ts and test - Remove unconditional subgraphs.delete in unpackSubgraph - Regenerate pnpm-lock.yaml Amp-Thread-ID: https://ampcode.com/threads/T-019cbfdf-bf82-76de-b36c-91758530a0ce Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 03/05/2026, 09:59:33 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
Playwright: ❌ 552 passed, 1 failed · 2 flaky ❌ Failed Tests📊 Browser Reports
|
|
Updating Playwright Expectations |
Description
Backport of #9282 (fix: stabilize nested subgraph promoted widget resolution) to
cloud/1.40, including its prerequisite #8856 (feat: synthetic widgets getter for SubgraphNode, proxy-widget-v2).Cherry-picked PRs (in order)
3e4d27383) — fix: update imagePreview browser tests to use current fixture APIsc25f9a0e9) — feat: synthetic widgets getter for SubgraphNode (proxy-widget-v2)dd1a1f77d) — fix: stabilize nested subgraph promoted widget resolutionBackport adjustments
svgBitmapCache.tsfrom fix: pre-rasterize SubgraphNode SVG icon to bitmap canvas #9172 (intermediate dependency not on cloud/1.40)drawImagecall to useworkflowBitmapCache(from fix: pre-rasterize SubgraphNode SVG icon to bitmap canvas #9172)getWidget3-arg signature indomWidget.tsanddomWidgetStore.test.ts(cloud/1.40 had 2-arg version)subgraphs.deleteinunpackSubgraph(duplicated byremove()guard logic)SubgraphBreadcrumb.vue,domWidget.ts,useGraphNodeManager.ts,LGraph.ts,LGraph.test.ts,SubgraphNode.tspnpm-lock.yamlVerification
pnpm typecheck✅pnpm test:unit✅ (all 5126 tests pass; 1 pre-existing flaky perf test excluded)┆Issue is synchronized with this Notion page by Unito