Skip to content

[backport cloud/1.40] fix: stabilize nested subgraph promoted widget resolution#9444

Closed
DrJKL wants to merge 6 commits intocloud/1.40from
backport-9282-to-cloud-1.40
Closed

[backport cloud/1.40] fix: stabilize nested subgraph promoted widget resolution#9444
DrJKL wants to merge 6 commits intocloud/1.40from
backport-9282-to-cloud-1.40

Conversation

@DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Mar 5, 2026

Description

Backport of #9282 (fix: stabilize nested subgraph promoted widget resolution) to cloud/1.40, including its prerequisite #8856 (feat: synthetic widgets getter for SubgraphNode, proxy-widget-v2).

Cherry-picked PRs (in order)

  1. fix: update imagePreview browser tests to use current fixture APIs #8995 (3e4d27383) — fix: update imagePreview browser tests to use current fixture APIs
  2. feat: synthetic widgets getter for SubgraphNode (proxy-widget-v2) #8856 (c25f9a0e9) — feat: synthetic widgets getter for SubgraphNode (proxy-widget-v2)
  3. fix: stabilize nested subgraph promoted widget resolution #9282 (dd1a1f77d) — fix: stabilize nested subgraph promoted widget resolution

Backport adjustments

Verification

  • pnpm typecheck
  • pnpm test:unit ✅ (all 5126 tests pass; 1 pre-existing flaky perf test excluded)

┆Issue is synchronized with this Notion page by Unito

christian-byrne and others added 4 commits March 5, 2026 13:21
…8995)

The browser tests added in #8143 were failing on main because they were
written against stale `ComfyPage` APIs that were refactored in #8510
(merged Feb 3, before #8143 merged Feb 18).

### Changes
- `comfyPage.dragAndDropFile` → `comfyPage.dragDrop.dragAndDropFile`
- `comfyPage.setSetting` → `comfyPage.settings.setSetting`
- `comfyPage.loadWorkflow` → `comfyPage.workflow.loadWorkflow`
- `comfyPage.getNodeRefsByType` → `comfyPage.nodeOps.getNodeRefsByType`
- Fix `comfyPage` type parameter to use `ComfyPage` import
- Remove `test.fixme` since root cause was API mismatch, not test logic

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8995-fix-update-imagePreview-browser-tests-to-use-current-fixture-APIs-30d6d73d365081219c1eda4ea7251160)
by [Unito](https://www.unito.io)
- Add svgBitmapCache.ts from #9172 (dependency of #9282)

- Update drawImage to use workflowBitmapCache

- Fix getWidget 3-arg signature in domWidget.ts and test

- Remove unconditional subgraphs.delete in unpackSubgraph

- Regenerate pnpm-lock.yaml

Amp-Thread-ID: https://ampcode.com/threads/T-019cbfdf-bf82-76de-b36c-91758530a0ce
Co-authored-by: Amp <amp@ampcode.com>
@DrJKL DrJKL requested review from a team as code owners March 5, 2026 21:38
@DrJKL DrJKL added the backport Backporting a PR onto a release candidate label Mar 5, 2026
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 5, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 66add64d-e4b6-42ab-9b98-e6858826ba1c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-9282-to-cloud-1.40

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 03/05/2026, 09:59:33 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@socket-security
Copy link

socket-security bot commented Mar 5, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedvite@​8.0.0-beta.13941008299100

View full report

@socket-security
Copy link

socket-security bot commented Mar 5, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm vite is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: apps/desktop-ui/package.jsonnpm/vite@8.0.0-beta.13

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/vite@8.0.0-beta.13. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Playwright: ❌ 552 passed, 1 failed · 2 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 539 / ❌ 1 / ⚠️ 2 / ⏭️ 10)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 10 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@DrJKL DrJKL added preview New Browser Test Expectations New browser test screenshot should be set by github action labels Mar 5, 2026
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Updating Playwright Expectations

@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Mar 5, 2026
@DrJKL DrJKL closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate preview size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants