Skip to content

fix: stabilize flaky screenshot tests that rely on search box timings #9426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 3 commits into from
Mar 5, 2026
Merged

fix: stabilize flaky screenshot tests that rely on search box timings #9426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0db4dd8
fix: stabilize flaky screenshot tests for search results and image pr…
christian-byrne Mar 5, 2026
fe7d994
fix: revert no_workflow.webp /view wait that times out in CI
christian-byrne Mar 5, 2026
37c29af
[automated] Update test expectations
invalid-email-address Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions browser_tests/fixtures/components/ComfyNodeSearchBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,22 @@ export class ComfyNodeSearchBox {

async fillAndSelectFirstNode(
nodeName: string,
options?: { suggestionIndex: number }
options?: { suggestionIndex?: number; exact?: boolean }
) {
await this.input.waitFor({ state: 'visible' })
await this.input.fill(nodeName)
await this.dropdown.waitFor({ state: 'visible' })
await this.dropdown
.locator('li')
.nth(options?.suggestionIndex || 0)
.click()
if (options?.exact) {
await this.dropdown
.locator(`li[aria-label="${nodeName}"]`)
.first()
.click()
} else {
await this.dropdown
.locator('li')
.nth(options?.suggestionIndex || 0)
.click()
}
}

async addFilter(filterValue: string, filterType: string) {
Expand Down
4 changes: 3 additions & 1 deletion browser_tests/tests/nodeSearchBox.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ test.describe('Node search box', { tag: '@node' }, () => {
await comfyPage.canvasOps.disconnectEdge()
await expect(comfyPage.searchBox.input).toHaveCount(1)
await comfyPage.page.locator('.p-chip-remove-icon').click()
await comfyPage.searchBox.fillAndSelectFirstNode('KSampler')
await comfyPage.searchBox.fillAndSelectFirstNode('KSampler', {
exact: true
})
await expect(comfyPage.canvas).toHaveScreenshot(
'added-node-no-connection.png'
)
Expand Down
Loading